From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arvind Chauhan <arvind.chauhan@arm.com>,
Ips Gandhi <inderpal.s@samsung.com>, Nishanth Menon <nm@ti.com>,
Chander Kashyap <chander.kashyap@linaro.org>,
Pavel Machek <pavel@ucw.cz>, "Brown, Len" <len.brown@intel.com>,
Chander Kashyap <k.chander@samsung.com>
Subject: Re: [PATCH V5] PM/OPP: discard duplicate OPPs
Date: Thu, 22 May 2014 01:48:43 +0200 [thread overview]
Message-ID: <5258228.rMTDJps2Fm@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohponU2feK9+9sUn4tu0t4fhwSy6PZuaAO3zkF7qRejCwM1Q@mail.gmail.com>
On Wednesday, May 21, 2014 09:33:42 AM Viresh Kumar wrote:
> On 21 May 2014 02:39, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >> + /* Duplicate OPPs ? */
> >> + if (new_opp->rate == opp->rate) {
> >> + int ret = (new_opp->u_volt == opp->u_volt) && opp->available ?
> >> + 0 : -EEXIST;
> >
> > The parens are not necessary. And is the direction correct?
>
> What do you mean by direction here ?
The case in which we want to return 0. Never mind, it's OK. The parens are still
not necessary, though.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-05-21 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 14:53 Viresh Kumar
2014-05-20 15:19 ` Nishanth Menon
2014-05-20 21:09 ` Rafael J. Wysocki
2014-05-21 4:03 ` Viresh Kumar
2014-05-21 23:48 ` Rafael J. Wysocki [this message]
2014-05-22 4:05 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5258228.rMTDJps2Fm@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=arvind.chauhan@arm.com \
--cc=chander.kashyap@linaro.org \
--cc=inderpal.s@samsung.com \
--cc=k.chander@samsung.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®