mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: allow tags between co-developed-by and their sign-off
Date: Mon, 23 Oct 2023 11:24:49 +0200	[thread overview]
Message-ID: <5258664f-1f1f-6f3d-33ca-c3b2d60601b6@intel.com> (raw)
In-Reply-To: <fbd86466d325055846e5d63f62ca1dc8613ba80d.camel@perches.com>

On 10/21/23 00:34, Joe Perches wrote:
> On Fri, 2023-10-20 at 15:21 +0200, Przemek Kitszel wrote:
>> Allow additional tags between Co-developed-by: and Signed-off-by:.
>> Bump severity of missing SoB to ERROR.
>>
>> Additional tags between Co-developed-by and corresponding Signed-off-by
>> could include Reviewed-by tags collected by Submitter, which is also
>> a Co-developer, but should sign-off at the very end of tags provided by
>> themself.
>>
>> Missing SoB is promoted to error while that piece of code is touched.
>>
>> Two sets of perl %hashes introduced to keep both (int) line numbers and
>> (string) messages handy for warning reporting, while keeping it correct
>> across 100+ line long commit messages.
>>
>> Mateusz Polchlopek <mateusz.polchlopek@intel.com> has reported this to me.
>>
>> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> 
> Unless this is accepted by various process folk,
> and the documentation for it updated, I think this
> should not be applied.

I will post v2 with docs updated. Would make it clear in commit message
that immediateness of SoB after CdB was important for humans checking
presence of both manually, and checkpatch has adopted such requirement
for it's own comfort.


  reply	other threads:[~2023-10-23  9:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 13:21 Przemek Kitszel
2023-10-20 22:34 ` Joe Perches
2023-10-23  9:24   ` Przemek Kitszel [this message]
2023-10-24 20:07     ` Joe Perches
2023-10-23 10:28 Przemek Kitszel
2023-10-23 14:02 ` Sean Christopherson
2023-10-24  9:15   ` Przemek Kitszel
2023-10-29  9:35     ` Krzysztof Kozlowski
2023-10-30  9:05       ` Przemek Kitszel
2023-10-23 14:16 ` Lukas Bulwahn
2023-10-23 14:25   ` Joe Perches
2023-10-24  9:15   ` Przemek Kitszel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5258664f-1f1f-6f3d-33ca-c3b2d60601b6@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=apw@canonical.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=jacob.e.keller@intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®