From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5E0C433EF for ; Wed, 1 Jun 2022 03:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349489AbiFADt1 (ORCPT ); Tue, 31 May 2022 23:49:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233702AbiFADtX (ORCPT ); Tue, 31 May 2022 23:49:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 01855E6B for ; Tue, 31 May 2022 20:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654055360; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ZG0/fOlftf51d/HCO+fdLg9BUlxBwfKtSrN1+VicIE=; b=aVK7kQaoq7c0ON9grjL8ZgxkQ3FlDdViWirbt2995lA826iBJR6lnAghToRFFZP6lFJCcP PsiLycsvKC4RGDpv/vpICBHsNQ8f8I2P8i49dc9JpBAUWFfB11A8xuMSSbqmafULBOTkxe 76yuMswJhH2AkAUiiOBlsbNypmNTG2M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-76I8nYocM8SXstKquykPdQ-1; Tue, 31 May 2022 23:49:17 -0400 X-MC-Unique: 76I8nYocM8SXstKquykPdQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 469F7107EA01; Wed, 1 Jun 2022 03:49:16 +0000 (UTC) Received: from [10.72.12.91] (ovpn-12-91.pek2.redhat.com [10.72.12.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22985492C3B; Wed, 1 Jun 2022 03:49:10 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH v3 00/16] arch_topology: Updates to add socket support and fix cluster ids To: Sudeep Holla , linux-kernel@vger.kernel.org Cc: Atish Patra , Atish Patra , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Qing Wang , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Rob Herring References: <20220525081416.3306043-1-sudeep.holla@arm.com> From: Gavin Shan Message-ID: <5258e7c2-7829-af20-6416-1a40a09d1917@redhat.com> Date: Wed, 1 Jun 2022 11:49:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20220525081416.3306043-1-sudeep.holla@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudeep, On 5/25/22 4:14 PM, Sudeep Holla wrote: > This version updates cacheinfo to populate and use the information from > there for all the cache topology. Sorry for posting in the middle of > merge window but better to get this tested earlier so that it is ready > for next merge window. > > This series intends to fix some discrepancies we have in the CPU topology > parsing from the device tree /cpu-map node. Also this diverges from the > behaviour on a ACPI enabled platform. The expectation is that both DT > and ACPI enabled systems must present consistent view of the CPU topology. > > Currently we assign generated cluster count as the physical package identifier > for each CPU which is wrong. The device tree bindings for CPU topology supports > sockets to infer the socket or physical package identifier for a given CPU. > Also we don't check if all the cores/threads belong to the same cluster before > updating their sibling masks which is fine as we don't set the cluster id yet. > > These changes also assigns the cluster identifier as parsed from the device tree > cluster nodes within /cpu-map without support for nesting of the clusters. > Finally, it also add support for socket nodes in /cpu-map. With this the > parsing of exact same information from ACPI PPTT and /cpu-map DT node > aligns well. > > The only exception is that the last level cache id information can be > inferred from the same ACPI PPTT while we need to parse CPU cache nodes > in the device tree. > > P.S: I have not cc-ed Greg and Rafael so that all the users of arch_topology > agree with the changes first before we include them. > > v2[2]->v3: > - Dropped support to get the device node for the CPU's LLC > - Updated cacheinfo to support calling of detect_cache_attributes > early in smp_prepare_cpus stage > - Added support to check if LLC is valid and shared in the cacheinfo > - Used the same in arch_topology > > v1[1]->v2[2]: > - Updated ID validity check include all non-negative value > - Added support to get the device node for the CPU's last level cache > - Added support to build llc_sibling on DT platforms > > [1] https://lore.kernel.org/lkml/20220513095559.1034633-1-sudeep.holla@arm.com > [2] https://lore.kernel.org/lkml/20220518093325.2070336-1-sudeep.holla@arm.com > > Sudeep Holla (16): > cacheinfo: Use of_cpu_device_node_get instead cpu_dev->of_node > cacheinfo: Add helper to access any cache index for a given CPU > cacheinfo: Move cache_leaves_are_shared out of CONFIG_OF > cacheinfo: Add support to check if last level cache(LLC) is valid or shared > cacheinfo: Allow early detection and population of cache attributes > arch_topology: Add support to parse and detect cache attributes > arch_topology: Use the last level cache information from the cacheinfo > arm64: topology: Remove redundant setting of llc_id in CPU topology > arch_topology: Drop LLC identifier stash from the CPU topology > arch_topology: Set thread sibling cpumask only within the cluster > arch_topology: Check for non-negative value rather than -1 for IDs validity > arch_topology: Avoid parsing through all the CPUs once a outlier CPU is found > arch_topology: Don't set cluster identifier as physical package identifier > arch_topology: Drop unnecessary check for uninitialised package_id > arch_topology: Set cluster identifier in each core/thread from /cpu-map > arch_topology: Add support for parsing sockets in /cpu-map > > arch/arm64/kernel/topology.c | 14 ----- > drivers/base/arch_topology.c | 92 +++++++++++++++++---------- > drivers/base/cacheinfo.c | 114 +++++++++++++++++++++------------- > include/linux/arch_topology.h | 1 - > include/linux/cacheinfo.h | 3 + > 5 files changed, 135 insertions(+), 89 deletions(-) > I tried this series on virtual machine where ACPI is enabled and looks good. Especially for PATCH[10], resolving the issue I have. So I provided my tested-by tag for it. Besides, I checked the changes related to ACPI part and looks to me either after the mentioned nits fixed. I leave the changes related to device-tree to be reviewed by the experts :) Thanks, Gavin