From: "Matias Bjørling" <m@bjorling.me>
To: "Rakesh Pandit" <rakesh@tuxera.com>, "Matias Bjørling" <mb@lightnvm.io>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"Javier González" <jg@lightnvm.io>
Subject: Re: [PATCH V2] lightnvm: include NVM Express driver if OCSSD is selected for build
Date: Thu, 21 Sep 2017 15:41:49 +0200 [thread overview]
Message-ID: <5259c471-285d-c361-ac68-2907e69aba79@bjorling.me> (raw)
In-Reply-To: <20170921134123.GA29325@dhcp-216.srv.tuxera.com>
On 09/21/2017 03:41 PM, Rakesh Pandit wrote:
> Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
> in config file before building kernel. Also append PCI to depends as
> select doesn't automatically add dependencies.
>
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> ---
>
> V2: appends 'depends' with PCI
>
> drivers/lightnvm/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> index ead61a9..2a953ef 100644
> --- a/drivers/lightnvm/Kconfig
> +++ b/drivers/lightnvm/Kconfig
> @@ -4,7 +4,8 @@
>
> menuconfig NVM
> bool "Open-Channel SSD target support"
> - depends on BLOCK && HAS_DMA
> + depends on BLOCK && HAS_DMA && PCI
> + select BLK_DEV_NVME
> help
> Say Y here to get to enable Open-channel SSDs.
>
>
Thanks Rakesh.
prev parent reply other threads:[~2017-09-21 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 13:41 Rakesh Pandit
2017-09-21 13:41 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5259c471-285d-c361-ac68-2907e69aba79@bjorling.me \
--to=m@bjorling.me \
--cc=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
--cc=rakesh@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®