From: Stephen Warren <swarren@wwwdotorg.org>
To: Rhyland Klein <rklein@nvidia.com>,
Anton Vorontsov <anton@enomsg.org>,
David Woodhouse <dwmw2@infradead.org>,
Thierry Reding <thierry.reding@gmail.com>,
Darbha Sriharsha <dsriharsha@nvidia.com>,
Manish Badarkha <badarkhe.manish@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Rutland <Mark.Rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [Patch V5] drivers: power: Add support for bq24735 charger
Date: Mon, 14 Oct 2013 12:21:16 -0600 [thread overview]
Message-ID: <525C361C.1020703@wwwdotorg.org> (raw)
In-Reply-To: <1381526143-20800-1-git-send-email-rklein@nvidia.com>
On 10/11/2013 03:15 PM, Rhyland Klein wrote:
> From: Darbha Sriharsha <dsriharsha@nvidia.com>
>
> Adds support for the bq24735 charger chipset. The bq24735 is a
> high-efficiency, synchronous battery charger.
>
> It allows control of the charging current, input current, and the charger
> voltage DAC's through SMBus.
Please CC the DT bindings maintainers on patches that add DT bindings.
> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt
> +Optional properties :
> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter
> + presence.
Is that actually a property of the BQ24735 chip itself (i.e. is it an
output signal from the chip), or part of the board/system?
Aside from that, the binding looks reasonable to me (although I'm no
longer a DT bindings maintainer).
next prev parent reply other threads:[~2013-10-14 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 21:15 Rhyland Klein
2013-10-14 18:21 ` Stephen Warren [this message]
2013-10-14 18:26 ` Rhyland Klein
2013-10-14 18:40 ` Stephen Warren
2013-10-25 22:48 ` Anton Vorontsov
2013-10-25 22:55 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525C361C.1020703@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Mark.Rutland@arm.com \
--cc=anton@enomsg.org \
--cc=badarkhe.manish@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dsriharsha@nvidia.com \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rklein@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®