Re: [PATCH] bq2415x_charger: fix max battery regulation voltage

[Alexandre Belloni <alexandre.belloni@free-electrons.com>]

Hi,

I forgot to add this is a v2 and I just added a comment.

On 16/10/2013 16:08, Alexandre Belloni wrote:
> As per the datasheets, maximum battery regulation voltage is 4440mV.
>
> The formula is (voltage - offset) / step, so the maximum value is:
> (4440 - 3500) / 20 = 47
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/power/bq2415x_charger.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c
> index 0727f92..df893dd 100644
> --- a/drivers/power/bq2415x_charger.c
> +++ b/drivers/power/bq2415x_charger.c
> @@ -605,9 +605,13 @@ static int bq2415x_set_battery_regulation_voltage(struct bq2415x_device *bq,
>  {
>  	int val = (mV/10 - 350) / 2;
>  
> +	/*
> +	 * According to datasheet, maximum battery regulation voltage is
> +	 * 4440mV which is b101111 = 47.
> +	 */
>  	if (val < 0)
>  		val = 0;
> -	else if (val > 94) /* FIXME: Max is 94 or 122 ? Set max value ? */
> +	else if (val > 47)
>  		return -EINVAL;
>  
>  	return bq2415x_i2c_write_mask(bq, BQ2415X_REG_VOLTAGE, val,


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com