From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC92F1E32A2 for ; Mon, 16 Feb 2026 14:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771252278; cv=none; b=Lc+EkWBHlssYL1VdElMxvTl/tE76jDxTMUFNEDfRqNsmzluK8U1wsaILdfg/kJon+gwcNY9XUp95LwgKkGszz2TIB53hFRupw3ppfbYk0j33fe1VaQNmjxSWuE9F0auVEU0rT+WZTXKO+Cl88sgFt0fa9w6jfJOJiSGArvPcHe8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771252278; c=relaxed/simple; bh=oJ3Jb0H6XTUCs8eAjN0EUoQseEV7cBNbePIAUCcnQz4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=DcYlN3x/bIwxp91tiiPewh8mBBWnBm0fhvqOTfkWpcdfLhKkZVDkkSY9dGCMkKes/gSXkeOSYh/yD6sImdZjPtzBrZEvDju4dGUivlTDEpOsiHLa4anv2ItXH/k6GljnBl5brvmUmT/IT+s7zKMLPdLpCWBtw8BWeDRyWk4JlOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fTb6FrWM; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fTb6FrWM" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4376acce52eso2110523f8f.1 for ; Mon, 16 Feb 2026 06:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771252275; x=1771857075; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=WVzoSyFcsGuxxxP9dZCCrbalL3jLqSKHOVQs8wddW3o=; b=fTb6FrWM2osfCysXvIBt1vBoPqSCLhn8c8MUZfl4lmSIl6CFqfAeRQeWf0lDW+HQby izMrT8Sy9ptCBwio1W0lOJd0ttQCSejZbEeYDLKnxcW/eookXlL1U5pah6b8lOaMd2mS Ylqclsxz5cQjhrbtKsFkjJYDYNzAC8J4og1+KsF987qW+WF68GPAulw5fgoQmdHNMInS HHTz51iI+rnM0kpS7ha/zMoxv7U2qdMIYjoQY59+4x8cbEVG7zBvAXc6iv32WkC71aWL /VO8XiWxWfb3w9EwZmblt5KLsy5p7eZ3poTAwYgQsnevsmUKtSaT2OnntcXLZlXLuqhc qtlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771252275; x=1771857075; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WVzoSyFcsGuxxxP9dZCCrbalL3jLqSKHOVQs8wddW3o=; b=bbk9W9KZo44HFfbiQLKmMf7FsCz+f4K3aENbumks89iKeTC5oAiWtyyTX2p57z6VXh e4MRmtfEO8azmBYt+dKhBF21RAOUvu8Lm1hjtVHVJNpIw3QVnQ63j78uo/7daVUjJMbl T2s+wg12C74cZMyPBAiDwfECy1MzJ5XSmanW53kUttD75A0v/+twlfKJjBEO2+7IKPHR nbHUi9YOrpWTgU+cEV+OuoTYkrrurUYqQFr+o7JWjvyxI1QQM7shDHer2muq8iQvIJZY ORlfRlUrhkQ168rr88pCVfNNJHRGAMPQP8UCuPNyYdhnZFLDnX1nxrkgUMgCYFNmr7JP 3NDw== X-Forwarded-Encrypted: i=1; AJvYcCWuQzJ5L/uKvp0RUHu9lFTtDkjsYQhvt5BNafWt4JuXMpp4ooKtAt7TmjOBKeXeH9OkPhqlKVoiIFwqQ8g=@vger.kernel.org X-Gm-Message-State: AOJu0Yyr8dfbBwhAqfH+5ns25UnXQfdvLsK2tFCB+dSZHAqSKp+HDcbL NGPCONhqQomJn4kUIApwtOnGU5waYpckXZp6hylrxz4EUkBfdfZkEMLg X-Gm-Gg: AZuq6aJfxij5MQtXiRStD2bhc4l0jcB8gphDjVfdk9T0W2OPNH4SzQZd0URP4dPFghb U8fNEwle1h1aO7MGMGRmZc2tp+v+aq0G5w3sFa436y/Sq6dwMfPxTvwICOOg9qrpf+LBPsauqmr 0Y2AzLjkFZuAgdMVxnxZyvaXPyptGXPXJqnorjorND+BE6KLsHN5x8KO0klX+K7Z+JTsF422rHU gRQT4+9eDvNBnKrnzUzCXdLGtt+aTN34VT24xsjrtcHIPJ6sjPneGplVOslytHtsiqbpEL2n7U+ J6tnfBd52LAX7yjoeqodAS8wTISFix4NlU0mjOAn2k6XtJuzdBQ9keZrtWWNqNFd8Zj+FBABPAY zUyOiE70gfF6VIS2LCuvYzS0g61AiFJ10ZYXP/H8q8fMTyX6LwzOAuezkKNlKxgRTlCTfKe9rq+ oT78yoxD/s1IND9R8R6uiOP7TNDWJHghs= X-Received: by 2002:a05:6000:1aca:b0:437:75c1:5797 with SMTP id ffacd0b85a97d-437978cccfdmr19128938f8f.14.1771252274995; Mon, 16 Feb 2026 06:31:14 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ad112bsm27780377f8f.36.2026.02.16.06.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 06:31:14 -0800 (PST) Message-ID: <525a30ed9127b689549bfaedc086638e2e3b5670.camel@gmail.com> Subject: Re: [PATCH v1 1/1] iio: core: Simplify IIO core managed APIs From: Nuno =?ISO-8859-1?Q?S=E1?= To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko Date: Mon, 16 Feb 2026 14:31:57 +0000 In-Reply-To: <20260216081412.1118599-1-andriy.shevchenko@linux.intel.com> References: <20260216081412.1118599-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-02-16 at 09:14 +0100, Andy Shevchenko wrote: > Use devm_add_action_or_reset() instead of devres_alloc() and > devres_add(), which works the same. This will simplify the > code. There is no functional changes. >=20 > Signed-off-by: Andy Shevchenko > --- LGTM. Just one minor "complain". Anyways: Reviewed-by: Nuno S=C3=A1 > =C2=A0drivers/iio/buffer/kfifo_buf.c=C2=A0=C2=A0=C2=A0=C2=A0 | 29 +++++++= ++++++---------------- > =C2=A0drivers/iio/industrialio-trigger.c | 24 ++++++++++-------------- > =C2=A02 files changed, 23 insertions(+), 30 deletions(-) >=20 > diff --git a/drivers/iio/buffer/kfifo_buf.c b/drivers/iio/buffer/kfifo_bu= f.c > index 38034c8bcc04..a126cc05fb38 100644 > --- a/drivers/iio/buffer/kfifo_buf.c > +++ b/drivers/iio/buffer/kfifo_buf.c > @@ -224,9 +224,9 @@ void iio_kfifo_free(struct iio_buffer *r) > =C2=A0} > =C2=A0EXPORT_SYMBOL(iio_kfifo_free); > =C2=A0 > -static void devm_iio_kfifo_release(struct device *dev, void *res) > +static void devm_iio_kfifo_release(void *r) > =C2=A0{ > - iio_kfifo_free(*(struct iio_buffer **)res); > + iio_kfifo_free(r); > =C2=A0} > =C2=A0 > =C2=A0/** > @@ -234,23 +234,20 @@ static void devm_iio_kfifo_release(struct device *d= ev, void *res) > =C2=A0 * @dev: Device to allocate kfifo buffer for > =C2=A0 * > =C2=A0 * RETURNS: > - * Pointer to allocated iio_buffer on success, NULL on failure. > + * Pointer to allocated iio_buffer on success, error pointer on failure. > =C2=A0 */ > =C2=A0static struct iio_buffer *devm_iio_kfifo_allocate(struct device *de= v) > =C2=A0{ > - struct iio_buffer **ptr, *r; > - > - ptr =3D devres_alloc(devm_iio_kfifo_release, sizeof(*ptr), GFP_KERNEL); > - if (!ptr) > - return NULL; > + struct iio_buffer *r; > + int ret; > =C2=A0 > =C2=A0 r =3D iio_kfifo_allocate(); > - if (r) { > - *ptr =3D r; > - devres_add(dev, ptr); > - } else { > - devres_free(ptr); > - } > + if (!r) > + return ERR_PTR(-ENOMEM); > + > + ret =3D devm_add_action_or_reset(dev, devm_iio_kfifo_release, r); > + if (ret) > + return ERR_PTR(ret); > =C2=A0 > =C2=A0 return r; > =C2=A0} > @@ -275,8 +272,8 @@ int devm_iio_kfifo_buffer_setup_ext(struct device *de= v, > =C2=A0 struct iio_buffer *buffer; > =C2=A0 > =C2=A0 buffer =3D devm_iio_kfifo_allocate(dev); > - if (!buffer) > - return -ENOMEM; > + if (IS_ERR(buffer)) > + return PTR_ERR(buffer); Subtle change that could have been mentioned in the commit message.=20 - Nuno S=C3=A1