From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01B6C433F5 for ; Sun, 1 May 2022 17:58:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350782AbiEASCD (ORCPT ); Sun, 1 May 2022 14:02:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353631AbiEASB4 (ORCPT ); Sun, 1 May 2022 14:01:56 -0400 Received: from mxout04.lancloud.ru (mxout04.lancloud.ru [45.84.86.114]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0908B1BEB4; Sun, 1 May 2022 10:58:26 -0700 (PDT) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 1EE4B20A47F3 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH v3] sh: avoid using IRQ0 on SH3/4 To: Rich Felker , John Paul Adrian Glaubitz CC: , , Yoshinori Sato , Greg Kroah-Hartman References: <2584ba18-9653-9310-efc1-8b3b3e221eea@omp.ru> <11021433-66c0-3c56-42bd-207a5ae8d267@physik.fu-berlin.de> <20220429171623.GQ7074@brightrain.aerifal.cx> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <525e7383-d26a-fe35-7005-e1dd9b57f76f@omp.ru> Date: Sun, 1 May 2022 20:58:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220429171623.GQ7074@brightrain.aerifal.cx> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/29/22 8:16 PM, Rich Felker wrote: [...] >>> Using IRQ0 by the platform devices is going to be disallowed soon (see [1]) >>> and even now, when IRQ0 is about to be returned by platfrom_get_irq(), you >>> see a big warning. The code supporting SH3/4 SoCs maps the IRQ #s starting >>> at 0 -- modify that code to start the IRQ #s from 16 instead. >>> >>> The patch should mostly affect the AP-SH4A-3A/AP-SH4AD-0A boards as they >>> indeed use IRQ0 for the SMSC911x compatible Ethernet chip... >> >> Maybe try getting it landed through Andrew Morton's tree? > > Hi. I'm alive and looking at it. If it needs to go in for this cycle I > will send a pull request for just this and anything else critical. Was Well, now using IRQ0 just causes a WARNing in platform_get_irq() -- I don't think fixing it is critical enough. Starting from 5.19-rc1 the SMSC91xx driver should stop working on the mentioned boards. But let me look at the SMSC driver itself, I haven't done this yet... > trying to get to it last night but had some unpleasant surprises come > up that took me away from the computer. :-( > Rich MBR, Sergey