From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11021143.outbound.protection.outlook.com [40.107.192.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4CCC1B87DB for ; Mon, 20 Jan 2025 16:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.192.143 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737391761; cv=fail; b=Ddd5tEa5civjLgkpuFC3mgpZhZcIkTBrG0inWLKghy1st6tI5GIte0szO5HQHMiw9KxRdVgjmJnNpcKmpRCy5i+g5kiX9PQU1LMrXohMe5iagpckiyyKuBM8YSN9whUnX9LlMdg/SjMyZo2jQX90W/00rz3vSIDc3pwuC6KuMoc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737391761; c=relaxed/simple; bh=uyL16aPubWr4yEOFUdedtMDaDp8e3prjkbadeURYbCw=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=Tv7yOpCB62PfO7F8sPz3fre6GnzkSsdj0hYvyKfVmjQ1/ZgYrkA7xAJQTWNeTqgA3MtoQjyxbRVXsJ4rqbteyufP+J4JXUMZ9OOEO5xmqsRG0vTOo3zLPel+ERARUhY3BYRBxKAPvSsWQBL0MwnY9s8LCX977PiBrYS7biQIwtc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=RFiv+aP2; arc=fail smtp.client-ip=40.107.192.143 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="RFiv+aP2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qg+YdHt0FwAVLDl7txrL//X6YLK/2+VfdylBOlVbceCVUQXDj1t7dKN0EsWB9YLXLjlkeShErkkLgI5S3Sa9RxMmeVwNQjCuR582MuOSN7UUn7OomwB1j4EZLmA17HV208tf8UohtWNHxMW0uNSxt0stbjs9g45W48VRLBNC4G9G1JNA6XkZqoShpBtt6BK8cyrKhtEGSIDVxIGDcPeJBaE+wQqCP21vTi0Cw6GNXQwaNGvJpjfZpzU37Iwrzg6E993QGOHia84QRBK00dqyrCS+D/VPan8RiYCKj3/KhP459AgF4Nqj194felmYGPMShl/As1Md1qJxyfkHyaLRFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AcZPdbBt+h8zoGQnCDNqjlksLLfVNz+H4d4hE9eGvgU=; b=XZ4kHrdiYR0fFG7fJ9w+FA816X2CofRdbWOBFU4EdJhCIg1jrjyEtf5/anzJbOmFSeAa7nojIQmUpKjboa+YMXVtr+Ahsk+hu5z0Geu/yr+KZxFVUTsQP6nPYjzzvokeqOUk7151YIRfbciyrWGmv3eIodUtaTpMI1E/0C8dPo6IAtbLLUcOni3fMknSSGGqzAq2KqvCEZOELCSuTt1L0qbT8i1hj1jIHqP8iS2IrrWdafO0r+LWJHy5Zv9yidx3ZXp0rKaWCcbixagZiG2eMggOVZH/x6JQBZN5x7WnNgo66y1T0meulQllvp3hlkKsE9/KoQ5xiipSEpH2n7MH0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AcZPdbBt+h8zoGQnCDNqjlksLLfVNz+H4d4hE9eGvgU=; b=RFiv+aP26UCGj/cFSByaw2l1a9fYoZuSi7j5L3WAd2G6FJwK2abc4CwwDnq8EmAmtEWvqru4bZnhwP+JQqPk1j3THdhW3i6ce0H4FxUiuQG7PrSDOYbRMW8SPVeOcGxYQ8/1FRXnvmbqcMULIfMakC1q8dnDBnImNktysIvmcKUYnpPeZ1PglqNu8CwjMSgqTyLB5oBtOmMqdKAdmiQPT5xbwcVbKKoCSO8l//XahG8nGnB9n9SyDfv9ZJBiuhwM9RclQb1967/ccDvdBcUtmCfju/kMxL89JmgrmY7Vcjh8v/v/UAjecBr5WfvSpvRSikwZ1y1c/sdDmcHym4lK/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) by YT1PPF338B22536.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::520) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.22; Mon, 20 Jan 2025 16:49:16 +0000 Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::50f1:2e3f:a5dd:5b4]) by YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::50f1:2e3f:a5dd:5b4%4]) with mapi id 15.20.8356.020; Mon, 20 Jan 2025 16:49:16 +0000 Message-ID: <525f88ba-b082-4744-b54a-a23a264fb8a3@efficios.com> Date: Mon, 20 Jan 2025 11:49:14 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for sched/core] rseq: Fix rseq unregistration To: Peter Zijlstra , Ingo Molnar Cc: linux-kernel@vger.kernel.org References: <20250116205956.836074-1-mathieu.desnoyers@efficios.com> From: Mathieu Desnoyers Content-Language: en-US In-Reply-To: <20250116205956.836074-1-mathieu.desnoyers@efficios.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0076.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:3::12) To YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT2PR01MB9175:EE_|YT1PPF338B22536:EE_ X-MS-Office365-Filtering-Correlation-Id: d9216739-d299-4769-b064-08dd3972607f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bHZVbTRKYmNLMXhwU3FkcWMwdEhLWUxvdmhVQzBSUnNVQ09SdUE3R2NkQ1R2?= =?utf-8?B?RWFPYjUxajBoL2NqdkZBNWZQV0RnWTBtTXRHdFhuQVRFNlVsK3lOT1dtbGdP?= =?utf-8?B?aDJHMTFxM21yQ3BQZ2dOL3BMd1AzTzB1U0FmV1NNQTNCNUtZUTdFbjRDQzdI?= =?utf-8?B?OFg2NGVtbmxpOHNDZHBJZFdJTUIxU0Y1RThYcU82RGJCOE5ORVdvNmtSNjB0?= =?utf-8?B?cXI5VEZtckFuZTQxb2puVnpVWFk0cm0vZjgzU1dNUUZINkxBTUJ3THVMQjFG?= =?utf-8?B?Um9Kd00xSUNnMGEwMXZnR2JkMnpVelpKdW5IZTVPclhZN2pQRXFNaG1WdXk1?= =?utf-8?B?emtBNzlMeUtneVRQc2lVeFJ4RlE1UENEMmVOWDEwaC9GVy9zUFRXY05lM3pX?= =?utf-8?B?UzFJeWwybTh3OUppTG1tRm02aEhGRnhncnlXZjJuZ2RGTUwwS1dlMktFK1Fv?= =?utf-8?B?eEhDaGpIUTM4bkpjS0FkbWNkV1F0SDN4b1UzMVFNL1dPS3FLODNIMTdlTmhy?= =?utf-8?B?cmE3a3Q1cUpiM1NPaGtGc3A3dGV1SFU1bU81aStpaC91Q0NKV0FCZWlLdC90?= =?utf-8?B?YWJqdGdjWlFmRzNRMGFZaGlJTW9sTDM4V2VVWVIvalk1d1UxSjVBWWUwREFQ?= =?utf-8?B?QlU5Z3gwcjd6MysrMkpvTnFmMnIyS3c4S0NWNlhQbmgxajlkN2lSVUR3YVQy?= =?utf-8?B?cW40QzVtRFBHSXBURS9NRFlkTlF6UVBqZC92cTlOZkJIRGF1cUZOd0c4TXVa?= =?utf-8?B?R0N5aVpKcUphWnlXb05kZ2tERlhWeXlUOFFja2VSSkVuaTFWYy9FOXNUSDFr?= =?utf-8?B?ZlFPS1UxSy80UUo2SVN3V2o3M2hkbmw0UmtnU2JBbGFWN1hRTjdHbldVWTJn?= =?utf-8?B?UzRtd0o0UlJDTDF5VUtqUlppR3dseFowdWsxL0xFcWR2bnZEL0VITXo1dmMv?= =?utf-8?B?TitTMzNZc3lqQ05wWnFxdDZqUjV0VzF5WXYyZis1NFgxaWhCL0Z1ODhxQ0Rq?= =?utf-8?B?V1ZkQ3JkM3lMK21yZ0xjRURtdkxReWFWV3d3SkRMME5FeWdsUUgzdnRlcEVC?= =?utf-8?B?d25BTklSMVJXb3ZNSmNhUmRrdnUvWFdYeEZ6TXlkOS9leWc2UjBZWDVXTmNp?= =?utf-8?B?UjZzSXV3MGRmVWxBVWhHNEovbk52NUhhK1V0UVVWVldYNmxnRW55alQxRXpw?= =?utf-8?B?M0xMam5XenRyVUV4cjNQQVphRkoxd1hJNnUxanlSUStJOURRbERZLzBMSW80?= =?utf-8?B?U3BYaXRwcXp1VVQ1QnZNUzdMRjhJYXZoYkk1Q1U0NG0rSE1tN0p0dVBEbHpB?= =?utf-8?B?UXhsM1FhQ3VMblBtYk0vQ3dXWW90bzlYTjA4bCtPM1lycHpFc2NxSUxqWXp6?= =?utf-8?B?QWNPL05QaDZVMDUyRGx2NnJLQzNOblRzemZOUnh4UmlDazFvTDJzZTdQbk43?= =?utf-8?B?RWJTVjRsNyt6SnQ2bkFhL1J6K25mWGdSUDR3Ukx0TitmRUxjMWo4TTB2YWEv?= =?utf-8?B?dkp5Z1ZQdm9rZjVFK2JnRmUzRXRocmY5RU1wUk9vU3RYUVBVQ2VxdmpkTE1U?= =?utf-8?B?Rjd3U0FiZHVtMTdjb01CeFBNMENLclpOZjR4andjdVJNVnJXV3IxTHJZZDF1?= =?utf-8?B?R0xvRVhaYmVlbE5Zc0F1Z1hPS2FkVDBGaDl6M1NXeU1ZYzRjVUtMU3U2UVBN?= =?utf-8?B?b2tZK0lhV1lINW9QSUcxU2w2cTRJOExUeUpHcTUvY2pVa05HTjdyS2dNcjMr?= =?utf-8?Q?0E+QxhvMneliNi8tkzqPko54N+6W7x/pMxt8QsN?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzNHRndvcStmcGw4ZVJGb3lqbytBZSs0NmkyQlBTZXZiejZMWktNUzVUcFZT?= =?utf-8?B?YWRpV0NNWXRFTDE0TWdmVWtCbEdiK0Q2RDkvK1BtNHp2SEk2eUdEUTZVT1pm?= =?utf-8?B?ZzdwSkp4NVc0Q05hVUdlLzZXQ1pDa3ZXd2JDK2pXQlAzYzErei81T0R4eGdl?= =?utf-8?B?Q1dnRVMyVkpzQVRaTlJ2Z1VhbHJ5eUtvNllNKzc1S0M2emFuUnhtaFkvcldQ?= =?utf-8?B?R3AxTTJqbnFzTzJQRlY4QTF1VXNaRm9YTGYwd00yZS91T0RFQksrR1puaFVF?= =?utf-8?B?R3FoeUpWdE1Cd1IveGNHdU1ieGV1Z0c2dFpPakR0dEdkR2ZkdHdKMDFDaHN3?= =?utf-8?B?ZmttRFQrRmp0M0ZhSEhTRFR2c0lnVCtTbEllSlhra08wOFNSNFNVcDYwWDJl?= =?utf-8?B?YnNBWVBWb1RjeHQwRjRTN2dYU2E0S3FjbjRiZWtaUUphNFVoYVJjY2VHVTY2?= =?utf-8?B?bUpHUVdvcTkxcDBjWVZzVEF0VHpORnhaUUtIOWVsQ0VmU1lNMXhXekFwVTBT?= =?utf-8?B?ZlB6dm9tMVNNck1Oc0dCUEl1NUNqeHN0Rmk5QjFUeW5QQUQ4SDdHMk9ibWpJ?= =?utf-8?B?aEVVTGdRbVpLZ3dLbHR6aWJhSFcySWtOcW50WTdkRWRXeTNvVEFyQ1BDa3Az?= =?utf-8?B?cUJIZmpobGowVlhGdnlPNmZ6QzdMRHhmUWNobmpBdjVpWXIzRHc5YmtocW9U?= =?utf-8?B?ZGFXR21KR01SaEttd00vMkROSFNnU05sODNEbmJabEZJNGttQXYvbzFBZzdD?= =?utf-8?B?SGJrN200RUlnTE1WZkk5bitjRGNJaGFIVDQwTXJBYWFlYnlTWmovTlFTcFFw?= =?utf-8?B?aWFaRXRVV0ZWQVBDUnNPdlVVOWZjdjF6WU82UEFwbGZxemRhMUZNVmF3N2ht?= =?utf-8?B?emdQemlQVkV2OCtkeVhYU2IwUldtU0tuNnJ2c1dyMFY5dzFBMFVKQmVkd2Rt?= =?utf-8?B?bENsbEtKeHRlLzZoNXBUbzhNbFd4REpZQXBvbkdHaWVwd1lGTk1mdVFUcUVP?= =?utf-8?B?bm05ZHZXMmY2MFBja2RFd21la1hXTlR6cy9zeFpubFhobnhEK1RzWTVOaW1J?= =?utf-8?B?UXVJMitqK2RaOFpHbnEvTkN6Wk9pRERuOVgxMjFoMzZtVkZQbnY4VTk0TEFO?= =?utf-8?B?czRZeGVqQVBYSU1jR20xMTNRcnZOdGJ2S1NWMVA5UHRsZk42RUpyR0F2aVBT?= =?utf-8?B?SlFvRDdFNUwrbTlDOS9Hc0pWMllNdTFmSlJPL2NmVmRVOVhsYWNtUDZHUEN5?= =?utf-8?B?eEIrMkVRcWxqQnQ0U1hNU2c2SXFOYkRHbnpZUHE5SUg2SStqbmFIeXpsejBM?= =?utf-8?B?TjFEdzkxdjY5VXNkYzh3MUlUZjdtZmFQZ2VHakV0Z0JOVGZ4eFptRlBQbkNv?= =?utf-8?B?ejlqUi9TR3ZUbFVUczUwZSs3aDlJZzVlQmNJbFVDSG1nQ2lrdzdtTUJSOGpE?= =?utf-8?B?REg1RDd5MkpudkQzOFFDbGN0WklJNEE0Skk0V1dIeisvdldGQUN1SEt4Y01W?= =?utf-8?B?SlloMUd4dTNZeHNGa1BpVkYwN09LdFpRWEFlbnlwOCtROWtyYTI2M05Dekho?= =?utf-8?B?Z2lnVVNSZk0rRnF2UXZLekxvRXY2WG9CUXZvTjNYUnBEMTc3ZkZIR05DdEp6?= =?utf-8?B?b1FRNE1jQUIyODhycnNUMTZXT1RvR01xY3VUajZ2SW91ZG84dTBlYi9nUzRD?= =?utf-8?B?WlpjUU5GbGpveVJBWmp4Sm4wWkZJVXVSSktGeFJDcFdYcWI5QU9TMkJOd2FI?= =?utf-8?B?dWVZVmdVWHVscHRKb0hjN1BQTFBvNEJFVU52eWVBYnEyQ09TR0dLMzZQeERX?= =?utf-8?B?TkZlRDk3SDd5YUxGQjN4N3ZFTWpiVHBvU0xLMUZ4V09yU2pqdmdydFZ1Ryts?= =?utf-8?B?U3RZSGZSaG9DeHI0eHROczJFRXRsM3MvWTk4MFFtczFYRHhiNXNid0JGc0Q5?= =?utf-8?B?TXk2Wi9xQmVwNWszaFhzMEp3MnRZdFpvZDRhN0swY2oycXB6RjdtY2M4b0dG?= =?utf-8?B?UjJsS0VOT0owZU9vM2ZnR29oa0ExN2owa1hlNEJVT2svdlFtOVN5dDBKdllG?= =?utf-8?B?UmlhVS9aRytPdHlKd3dsMVlGdHczaGllRWhyVVVqUjRDU0Nvd1EvYmJIeHM4?= =?utf-8?B?d05RYjhYNmU3U1NjaUo0cU1YTE9WakhBOXJWM0NrMEFsQ2wwNk0wZ2I3ZTE0?= =?utf-8?Q?LgKH9RVg0tW4bLxXwFnhor8=3D?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9216739-d299-4769-b064-08dd3972607f X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2025 16:49:16.5955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tnCqETZMYHAJbvY6A6/YzyX48y3bYB7xYNYSE4biKXBMjU4PYO266zpxm59U65KomnLCFDaI0jGyNh+2LCfzTWeaIMfOuSuwfLbHw+2UFR8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PPF338B22536 On 2025-01-16 15:59, Mathieu Desnoyers wrote: > A logic inversion in rseq_reset_rseq_cpu_node_id() causes the rseq > unregistration to fail when rseq_validate_ro_fields() succeeds rather > than the opposite. > > This affects both CONFIG_DEBUG_RSEQ=y and CONFIG_DEBUG_RSEQ=n. > > Fixes: 7d5265ffcd8b ("rseq: Validate read-only fields under DEBUG_RSEQ config") > Signed-off-by: Mathieu Desnoyers > Cc: Peter Zijlstra (Intel) Ingo, Peter, this fix should have been part of the PR sent to Linus earlier today [1]. Otherwise rseq unregistration is broken. Thanks, Mathieu [1] https://lore.kernel.org/lkml/Z44ufdYZWaM50kxF@gmail.com/ > --- > kernel/rseq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/rseq.c b/kernel/rseq.c > index e04bb30a2eb8..442aba29bc4c 100644 > --- a/kernel/rseq.c > +++ b/kernel/rseq.c > @@ -201,7 +201,7 @@ static int rseq_reset_rseq_cpu_node_id(struct task_struct *t) > /* > * Validate read-only rseq fields. > */ > - if (!rseq_validate_ro_fields(t)) > + if (rseq_validate_ro_fields(t)) > return -EFAULT; > /* > * Reset cpu_id_start to its initial state (0). -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com