From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61296C433EF for ; Wed, 2 Mar 2022 09:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240393AbiCBJKs (ORCPT ); Wed, 2 Mar 2022 04:10:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240387AbiCBJKm (ORCPT ); Wed, 2 Mar 2022 04:10:42 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 81906BBE34 for ; Wed, 2 Mar 2022 01:09:57 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47B6B1396; Wed, 2 Mar 2022 01:09:57 -0800 (PST) Received: from [10.57.37.244] (unknown [10.57.37.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1F45B3F66F; Wed, 2 Mar 2022 01:09:56 -0800 (PST) Message-ID: <5263b251-53ee-aebd-80e3-79a8d47335eb@arm.com> Date: Wed, 2 Mar 2022 09:09:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] drm/panfrost: cleanup comments Content-Language: en-GB To: trix@redhat.com, robh@kernel.org, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20220301124339.264544-1-trix@redhat.com> From: Steven Price In-Reply-To: <20220301124339.264544-1-trix@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/03/2022 12:43, trix@redhat.com wrote: > From: Tom Rix > > For spdx > change tab to space delimiter > Use // for *.c > > Replacements > commited to committed, use multiline comment style > regsiters to registers > initialze to initialize > > Signed-off-by: Tom Rix Thanks, most of the changes look reasonable (although I've never understood the reason for using // for SPDX comments), but there's one below that I think needs rethinking. > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- > drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c | 2 +- > drivers/gpu/drm/panfrost/panfrost_issues.h | 6 ++++-- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +- > drivers/gpu/drm/panfrost/panfrost_regs.h | 2 +- > 5 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 96bb5a4656278..94b6f0a19c83a 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -562,7 +562,7 @@ static int panfrost_probe(struct platform_device *pdev) > > pfdev->coherent = device_get_dma_attr(&pdev->dev) == DEV_DMA_COHERENT; > > - /* Allocate and initialze the DRM device. */ > + /* Allocate and initialize the DRM device. */ > ddev = drm_dev_alloc(&panfrost_drm_driver, &pdev->dev); > if (IS_ERR(ddev)) > return PTR_ERR(ddev); > diff --git a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c b/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c > index b0142341e2235..77e7cb6d1ae3b 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c > +++ b/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +// SPDX-License-Identifier: GPL-2.0 > /* Copyright (C) 2019 Arm Ltd. > * > * Based on msm_gem_freedreno.c: > diff --git a/drivers/gpu/drm/panfrost/panfrost_issues.h b/drivers/gpu/drm/panfrost/panfrost_issues.h > index 8e59d765bf19f..4e7cf979ee67a 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_issues.h > +++ b/drivers/gpu/drm/panfrost/panfrost_issues.h > @@ -13,8 +13,10 @@ > * to care about. > */ > enum panfrost_hw_issue { > - /* Need way to guarantee that all previously-translated memory accesses > - * are commited */ > + /* > + * Need way to guarantee that all previously-translated memory accesses > + * are committed > + */ This file has a whole load of multiline comments that don't technically follow the coding style. Fixing just one comment makes the file inconsistent. Note we recently had a discussion about this[1] and decided to leave the comment style as is. And I have to admit in this instance avoiding the extra mostly-blank lines makes the list easier to read. The typo fix is obviously welcomed though! [1] https://lore.kernel.org/r/c7331489-ad04-0f35-224e-164f144fb819%40arm.com > HW_ISSUE_6367, > > /* On job complete with non-done the cache is not flushed */ > diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c > index 39562f2d11a47..d3f82b26a631d 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c > +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c > @@ -1,4 +1,4 @@ > -// SPDX-License-Identifier: GPL-2.0 > +// SPDX-License-Identifier: GPL-2.0 > /* Copyright 2019 Linaro, Ltd, Rob Herring */ > > #include > diff --git a/drivers/gpu/drm/panfrost/panfrost_regs.h b/drivers/gpu/drm/panfrost/panfrost_regs.h > index 6c5a11ef1ee87..efe4b75149d35 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_regs.h > +++ b/drivers/gpu/drm/panfrost/panfrost_regs.h > @@ -292,7 +292,7 @@ > #define AS_FAULTADDRESS_LO(as) (MMU_AS(as) + 0x20) /* (RO) Fault Address for address space n, low word */ > #define AS_FAULTADDRESS_HI(as) (MMU_AS(as) + 0x24) /* (RO) Fault Address for address space n, high word */ > #define AS_STATUS(as) (MMU_AS(as) + 0x28) /* (RO) Status flags for address space n */ > -/* Additional Bifrost AS regsiters */ > +/* Additional Bifrost AS registers */ > #define AS_TRANSCFG_LO(as) (MMU_AS(as) + 0x30) /* (RW) Translation table configuration for address space n, low word */ > #define AS_TRANSCFG_HI(as) (MMU_AS(as) + 0x34) /* (RW) Translation table configuration for address space n, high word */ > #define AS_FAULTEXTRA_LO(as) (MMU_AS(as) + 0x38) /* (RO) Secondary fault address for address space n, low word */