mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "Ingo Molnar" <mingo@kernel.org>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: "John Stultz" <john.stultz@linaro.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] x86: honor ACPI FADT flag indicating absence of a CMOS RTC
Date: Mon, 21 Oct 2013 09:31:57 +0100	[thread overview]
Message-ID: <5265029D02000078000FC4D2@nat28.tlf.novell.com> (raw)
In-Reply-To: <20131018105923.GB17696@gmail.com>

Even though the omission was found only during code review (originally
in the Xen hypervisor, looking through ACPI v5 flags and their meanings
and uses), we shouldn't be creating a corresponding platform device in
that case.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Emit a log message in this case, as requested by Ingo.
---
 arch/x86/kernel/rtc.c |    8 ++++++++
 1 file changed, 8 insertions(+)

--- 3.12-rc6/arch/x86/kernel/rtc.c
+++ 3.12-rc6-x86-ACPI-no-RTC/arch/x86/kernel/rtc.c
@@ -192,6 +192,14 @@ static __init int add_rtc_cmos(void)
 	if (mrst_identify_cpu())
 		return -ENODEV;
 
+#ifdef CONFIG_ACPI
+	if (acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC) {
+		/* This warning can likely go away again in a year or two. */
+		pr_info("ACPI: not registering RTC platform device\n");
+		return -ENODEV;
+	}
+#endif
+
 	platform_device_register(&rtc_device);
 	dev_info(&rtc_device.dev,
 		 "registered platform RTC device (no PNP device found)\n");




  reply	other threads:[~2013-10-21  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16 11:37 [PATCH] " Jan Beulich
2013-10-18  6:29 ` Ingo Molnar
2013-10-18  7:37   ` Jan Beulich
2013-10-18 10:59     ` Ingo Molnar
2013-10-21  8:31       ` Jan Beulich [this message]
2013-10-26 13:51         ` [tip:timers/core] x86/time: Honor " tip-bot for Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5265029D02000078000FC4D2@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®