From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751262AbdFBQsf (ORCPT ); Fri, 2 Jun 2017 12:48:35 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:33888 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbdFBQsc (ORCPT ); Fri, 2 Jun 2017 12:48:32 -0400 Subject: Re: [PATCH][V2] net: phy: marvell: make some functions static To: Colin King , Andrew Lunn , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170602141334.26506-1-colin.king@canonical.com> From: Florian Fainelli Message-ID: <5268b842-3784-36f7-7c6f-e1b4b670f8b5@gmail.com> Date: Fri, 2 Jun 2017 09:48:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170602141334.26506-1-colin.king@canonical.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2017 07:13 AM, Colin King wrote: > From: Colin Ian King > > functions m88e1510_get_temp_critical, m88e1510_set_temp_critical and > m88e1510_get_temp_alarm can be made static as they not need to be > in global scope. > > Cleans up sparse warnings: > "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?" > "symbol 'm88e1510_get_temp_critical' was not declared. Should it be > static?" > > Signed-off-by: Colin Ian King Reviewed-by: Florian Fainelli -- Florian