From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753108AbdKIALH (ORCPT ); Wed, 8 Nov 2017 19:11:07 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:32800 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751969AbdKIALE (ORCPT ); Wed, 8 Nov 2017 19:11:04 -0500 Subject: Re: [PATCH x86/urgent] bpf: emulate push insns for uprobe on x86 To: David Miller CC: , , , , , , , , References: <20171108213712.1232793-1-yhs@fb.com> <20171109.090647.824552877953564084.davem@davemloft.net> From: Yonghong Song Message-ID: <526920a7-0329-cc2b-0cae-1af221a48aee@fb.com> Date: Wed, 8 Nov 2017 16:10:19 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171109.090647.824552877953564084.davem@davemloft.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:200::5:e802] X-ClientProxiedBy: DM5PR19CA0048.namprd19.prod.outlook.com (10.173.167.162) To BN6PR15MB1827.namprd15.prod.outlook.com (10.174.239.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0dcdf1e5-f6dc-4c33-2548-08d5270646c5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:BN6PR15MB1827; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1827;3:JIIJ2zvxEP2IM0M6Lkwp2gARUEHc6p3Bc6bF7KAhpeRn75cVB2FLaGZVjV/CsLHOG+EagH/zHpYOjfrXJvdZTjQqQksHx9RtujkPK0jcInLgXGUB6ltUC54mveZBDd5mts3oJSR2VQ+bQvUB8jVpt++FfnpEprbM2Gxrs82teQvsDFwcmAtyZY7vQQA0f5by5lYnsqeY0sOKvR0q9zJ+ibxYEcvc2ZdeGNQ8xuS+h93M6eKFg8FWEMfFq1GxrtdK;25:htyoiQIYSDA7Oz9472xnri4CUB1UP7iSaRth7mnguinm/sQr0qxKLPpyNhr/09uy/UpHoGo0h6QqG45Hjfxgs0/NItOlXLUbYsfo9q3MkupRBe923noGjIxuigndg56mXq7Y27d7J7mEp3oHVsZERME4kSLH2j/ooUO//SZeuA9IUym7I7tqG0MSGZDDeQ41vuVmQeCoy8u68O0Osi1u72FARPjaSiahKhsQgasvfKUsNI45mml5PMys1ZSlks0aTtHi3JR+JVXBvJ/wdDorMJedR6BpTBcNUm+afLDSLvU2l+CPudScnDcZOSLPfOoZeDekhhWdXw4FsrEECy8zbQ==;31:5ndXaLwuCCyubRA0ksHKtHpMI3nw8yMeJjOh3H12cglCkWBcID36r7AHIjcQdBuC6ZwswmVlTKvbC4Sf58yODu5wLXnpwNtEdndtiaLWO2PUe0LByycsmto1RkNIhYBixn9Tv5MNrZNU0Wp0Rk3Qy+XNwWZGWJOaRF/9rKRLWhxFRFFuksjqU04qj9yH8ZTLtEh0lOXXihC4NUWb3TURsQuVfbLDpaLhmL+cZKUXoTw= X-MS-TrafficTypeDiagnostic: BN6PR15MB1827: X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1827;20:ol5gPjwoRpi7w+6EODw8l8kX+QGVFhm4toOippq0Sl8RLP5VZoGTM4MbFxL/7rb2SiaOgFK6wMs+EMrXeXx4xUpC8pAQ9UQbUm2ChMv1V7zPx/GqVYPVj+Zy4tLdy+5ZJv1+98T8wsryb4vPO9NuEV3baQMRokdib9u8X3ROpsSKwwVc4U6MVh+zz585xo6hegXwGeCKJjZ7wYrKVmF9aULiZciSRmYDbta2WA8dD8PAlliVmO1tu3Tp7/+kbpA31AEfDelPL1JCC8BGSuEPhTZpcTlRS8Vo4EwdJHRsgWlN5UNGC68X8f7QMs8B9TNc4HTapQzcOaRUe84AqXnY/6N+8NVFMlENH+E2lsHyl1Fsx2xticO/wm+ZR71qGL76BzN+s3XCNU2f9TJlV+AEN6s611V570qBVdvG9yNw6cZ6WXvGCf7fwYGbYZaNrOo2qzGVk5hAW4EE3jCv88+DejlV1jhnXpOMERqIpRzfuXwFIqjl99snYvtj785zHNAb;4:wzJP7JmmagtqotuWDk9CbiZhlcE3WJAoWfSmU2p0FMws0wN6WsNfdKXQ9IxzBTzKbrFhX5VcXB8+e4vvpyALwz7l9R1oZt33JRU7YXbP+jGfJhXrgC0Myv3kC74yFR1GP1mETwaR/1w1p4nYCvCNhMMwy0LdH55zLbqIkZzJ2f2a9z6AmzjWSF5PBaYdPEdIDEH1ULbveE2fYFlTgCFPUvF+BErSjshFa5QA6o5cHvZQyM63z+YJOACyPT3OxQOOyZ3C9Ru6isdGIdGJkS7yNguwERiKCVsgJr4k83VXKlJpXqnfSbtOusrTzdqwAtFh X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231021)(10201501046)(100000703101)(100105400095)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR15MB1827;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR15MB1827; X-Forefront-PRVS: 0486A0CB86 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(199003)(189002)(24454002)(6512007)(97736004)(53936002)(101416001)(2906002)(6246003)(50986999)(76176999)(54356999)(4326008)(105586002)(230700001)(33646002)(189998001)(47776003)(65956001)(6506006)(6486002)(229853002)(6666003)(106356001)(31686004)(65806001)(6116002)(6916009)(65826007)(2950100002)(5660300001)(305945005)(7736002)(478600001)(58126008)(316002)(68736007)(8676002)(218543002)(8936002)(36756003)(53546010)(50466002)(23676003)(67846002)(86362001)(31696002)(64126003)(25786009)(83506002)(81156014)(81166006)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1827;H:MacBook-Pro-52.dhcp.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjE1TUIxODI3OzIzOmNKbVZoNDMrN1FNUW9pbVRsMFdQMS9aUEtu?= =?utf-8?B?aGNGZG8vbW9WUVNBMDFEWmg2ay9GcWVPcjd4Q3VPY2MyYXZqTDNZeXZNQklH?= =?utf-8?B?MU8wbmhZNWtyWVZUZmVYSEVWemtNWDljNHoyOU54TGFIaG9WeHdKVkM2M1gr?= =?utf-8?B?RDRTMHRWbThybko2N2RIeWI4WUkrQ1VZVG4rOExlRERPRGIyRmU2Rmx0UXpW?= =?utf-8?B?SHF2dFdKdHM2YzZOcHVzeGE3bnA0MFJ2UmRhWFNQcWM2YlcwSCsydkl1VUdJ?= =?utf-8?B?UTBJa0ZMTHdORUs1WFhOb3VpRnJQTzc3N0YzZlludFBMR0NGK0cySkc5REYr?= =?utf-8?B?amdSTUZxU2J2aENESlFqazNWZU15dUwzb1pveUIvVEpWUGJ0WWt4VldNMndL?= =?utf-8?B?VXlVcmJrVnlCRGtHWEE4Q3pvMzRJZy9xQlp5UEtNME9TNXZjeFpndlpzbUJN?= =?utf-8?B?Y0JYSHZUUG9RcmdaeG1hbldNYnFNYUdQd2N6KzlWUnhRNktHNXFZdU1lRHla?= =?utf-8?B?NHpsVStJaWoyd21rcGo1cUJFM05EZXJyL3g2dFR6Y1Z5dmRQOU02dStiV0Fy?= =?utf-8?B?dVdxVlZ3clBpOVMxeURDazBSZ1ZLSFlFLzY5WDBEcUNiR3Y4a2ZQbVdsN0JZ?= =?utf-8?B?ZDgzMVhYd3hqMXlnODd5WjJjUStmRVZzcDdPV0JBTFp1ZFRJTUU0RzZ5anc5?= =?utf-8?B?a0k2MlFaL1MwdGdlOE1zSVNqRE5hMlZXSzF5VXpIUmJxRnh0Z2pxN1M2ZWFW?= =?utf-8?B?aHl4UUxBdks3YjlDYmVFdWcyK1U2THl4eUNQaU15TmJDQzk3eW81SEI0bmtQ?= =?utf-8?B?S3U1T1hucEkyZGZYRkM2MGpJWUFrUEgyeFJwZDZwK21oa2ZoSGlBZ1RXRitt?= =?utf-8?B?S2Nmcmk5QXp4RFFadVd2VmJyeE9Ub25MZGh0MHF0UDhkaFFmaWxnNU5nb0pE?= =?utf-8?B?ZXNqWUxLY0JaS3ZBOWhibVZGVnpzL0NwT01OME0zeXl6ei9KZGMyc2FZMEgw?= =?utf-8?B?NXRmcXRmV0Jmc2FERjRSUVUzR1k4c1JFdkVla1lYVEZFYW5FdlhQY2k1MnI0?= =?utf-8?B?SGZIY3ZzeCtCN0tRTURZampiK0pNWkFzVGhNOWZSSk5UK25LRnh0RWk0Y3Vx?= =?utf-8?B?ZTJJSkhPb1BCTXVRT1Y1S0VvckhTeHRFVkNPMW9iN0gvV3Q5Znc3SnFrazFi?= =?utf-8?B?S1ZWZmdwdDVndTVNeEZOeWEwenRZYXJjYVVNc0hNbjlBeHRJQXpTQ3JKbTNZ?= =?utf-8?B?TXlZdU96M2tHYzhlSmk5b1EvdWw4NGx0dllTOHhzVEFwb29ia3lDOWhtZkxq?= =?utf-8?B?SGorV0x6a3ZQT2RWc0FsU3BySW5GM3ZETDRvSEpiQjZ0eTA2S0FJdlJSZFJ1?= =?utf-8?B?UjdQSmlkT2p5WC9HZk5lM1FaY2NVUnovZjdFREJsSmczTzJkclJNZWQvek5o?= =?utf-8?B?ZWRZelYvY2hTVFg1S2R1ZndUbXRSclRBZ2NkVmJCd2R4R3dXeDZZVXg2TDhM?= =?utf-8?B?c2NPMUpjSmU3eHF0Q1o1UWJieVc5SWVaTFpKaWo5YVl6YzdZQkZIZjBtK2w0?= =?utf-8?B?TmJpcUgxcE9vcjhjYmdQZ1F4aVpSNFJWc2xIZzNSRjFzOXpDRE00cjFEQTBy?= =?utf-8?B?aStxc0FGZW13K05CU0Q0bnA1VDZQR0M2NWg1SVNlVXhvR2xRSkhTdmFlcGZY?= =?utf-8?B?My80aGpQZWhMaVNiWFhWc28yM3o0ZE9HYTFKQnMzVEZpSDNnU3dEbFNRVnl1?= =?utf-8?B?aURmeEQvUUJLQmtJRWk5UT09?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1827;6:rBSpnN9cxi6JaF8keDMCqQV8p2HaaJCQ4bmC9/KnWcwbxaaBNgv7DLCouJv3YTqJn4rEevkcrtN7q+hKiha6YgcCM8rkNL1dDcv5dCsrVaofFf/ODdMiQXXAWomNeyT4TIq0yh6qrBEfACqzS1C1knxXkk0KttDSOJPpR+bSYLBS0VY6U9u7hvio9/K6Vp7QIUN/nrKqH2BLQaRWZSK01gLtjXFTl9uu9QOkQlwRECif09O7I4A2HaKumtAyck7naMGLE30WCKC3u6IE3vkSt4gjNTUVnHRwZYKQ0L8tDOrPO8LqoQMsiqZ6FRojDr5TBkj2kzh+SONT3FO5x9wJiKuTPeR4p/XeoKw48oo87Bs=;5:GNk1S7qfS9wUYaX2qHIIgqqxJ2UxAol+vOx6u04snnO2orQrEesxEMw2u1qxj9S55ahcDTWAbO205VJF0WiUiS10MK9Igcv1cMra28+EAYv4oG0bMC2HepanfdluFOPFTCDsETZClyVb+Ecm63085L1M/NY3qD5JGPzUlOsuDsA=;24:RgzA6AUL3WnMLExG5+dd+tDT3JyytUZG6bLhie/KAA3spoXoFATAxdH8vfD6q9qcu0D9AVP3WwvYVN4IthI2nX229A6DI/qQRB1gzPkrbLc=;7:a8gkpc/KOQ9nCyRB6NCAR7c3cNKQq4G5y+Xx923+ixUwtLONP0tGi1O0bs14uI4OTsgyeWQn4aKdMq17emJ1ZPqjyCQR+ULnkY49Dpst6PcUlLQUT72B/gnmCVhkZNfkdyFMhtK2WYUCjetic2tVNXKsmY8EHHFQEfxqlnbyISQsTjdTyl6FMSMopGn6V3VOrddqH8BiioRzxmq50mNuxWG574seaOBKdJvKYFd9hJokO4rFjb8czlhd02ukjAHA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1827;20:xlZLfD2uqRDE5gVOBLMWMkSuOIM9bjd0tsWoFaoBHNM/Y+zsUkSeYUPI/Sa8RaRppxAxL4mO7+RAQWZYTL0Nvp+RAriAU+tcTJQ/Ri8pudospo1iwDIDM/VEjwYktPGVCu0RMc96T/xvv2ErRxcnxA6eh32P2ISS0H/8SulPrd0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2017 00:10:23.5124 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0dcdf1e5-f6dc-4c33-2548-08d5270646c5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1827 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-08_05:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/17 4:06 PM, David Miller wrote: > From: Yonghong Song > Date: Wed, 8 Nov 2017 13:37:12 -0800 > >> Uprobe is a tracing mechanism for userspace programs. >> Typical uprobe will incur overhead of two traps. >> First trap is caused by replaced trap insn, and >> the second trap is to execute the original displaced >> insn in user space. > ... > > I don't understand how this is bpf related, and if it is you don't > explain it well in the commit message. Right. This is not related to bpf. Will remove the "bpf" from the subject line in the next revision. > > Thank you. >