From: "Jan Beulich" <JBeulich@suse.com>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Cc: "David Vrabel" <david.vrabel@citrix.com>,
<Santosh.Jodh@citrix.com>, <xhejtman@ics.muni.cz>,
"xen-devel" <xen-devel@lists.xensource.com>,
<boris.ostrovsky@oracle.com>, <mukesh.rathor@oracle.com>,
<yuval.shaia@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [v1 1/2] xen/p2m: Create identity mappings for PFNs beyound E820 and PCI BARs
Date: Mon, 28 Oct 2013 09:51:23 +0000 [thread overview]
Message-ID: <526E41AB02000078000FD2E4@nat28.tlf.novell.com> (raw)
In-Reply-To: <CAErSpo5_DspGSffEHOqq_G0U27OdvYbiFK3QcxiZVFeRpoMaPw@mail.gmail.com>
>>> On 26.10.13 at 00:08, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Fri, Oct 25, 2013 at 9:03 AM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>> + unsigned long pfn, start, end, ok_pfns;
>> + char bus_addr[64];
>> + char *fmt;
>> +
>> + if (!pci_resource_len(pci_dev, i))
>> + continue;
>> +
>> + if (pci_resource_flags(pci_dev, i) == IORESOURCE_IO)
>
> You probably want:
>
> if (pci_resource_flags(pci_dev, i) & IORESOURCE_IO)
>
> here. And I don't understand what you're doing below, but my
> impression is you only care about MEM regions, not IO regions, so it
> seems like you might want to skip IO completely.
Yes indeed.
Jan
next prev parent reply other threads:[~2013-10-28 9:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 15:03 [PATCH v1] Set 1-1 P2M for PCI BARs and MCFG regions - if needed Konrad Rzeszutek Wilk
2013-10-25 15:03 ` [v1 1/2] xen/p2m: Create identity mappings for PFNs beyound E820 and PCI BARs Konrad Rzeszutek Wilk
2013-10-25 16:38 ` Konrad Rzeszutek Wilk
2013-10-25 22:08 ` Bjorn Helgaas
2013-10-28 9:51 ` Jan Beulich [this message]
2013-10-28 16:58 ` Konrad Rzeszutek Wilk
2013-10-29 8:23 ` Jan Beulich
2013-10-29 14:45 ` Konrad Rzeszutek Wilk
2013-10-29 14:55 ` Jan Beulich
2013-10-29 15:11 ` Konrad Rzeszutek Wilk
2013-10-29 15:30 ` Jan Beulich
2013-10-29 15:59 ` [Xen-devel] " Gordan Bobic
2013-10-25 15:03 ` [v1 2/2] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved for MCFG areas and setup 1-1 P2M Konrad Rzeszutek Wilk
2013-10-25 22:58 ` [Xen-devel] [PATCH v1] Set 1-1 P2M for PCI BARs and MCFG regions - if needed David Vrabel
2013-10-25 23:39 ` Konrad Rzeszutek Wilk
2013-10-28 16:52 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E41AB02000078000FD2E4@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=Santosh.Jodh@citrix.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=xen-devel@lists.xensource.com \
--cc=xhejtman@ics.muni.cz \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®