Re: [PATCH] dt-bindings: marvell: move MMP boards to common marvell directory

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 01/12/2023 17:17, Andrew Lunn wrote:
> On Fri, Dec 01, 2023 at 03:38:36PM +0100, Krzysztof Kozlowski wrote:
>> On 01/12/2023 15:34, Andrew Lunn wrote:
>>> On Fri, Dec 01, 2023 at 03:21:05PM +0100, Krzysztof Kozlowski wrote:
>>>> On 01/12/2023 14:51, Andrew Lunn wrote:
>>>>> On Fri, Dec 01, 2023 at 02:23:06PM +0100, Krzysztof Kozlowski wrote:
>>>>>> Marvell board bindings are spread over arm/marvell/ and arm/mrvl/
>>>>>> directories.  Move MMP board bindings from the latter to the former, to
>>>>>> keep all of them together.
>>>>>
>>>>> Hi Krzysztof
>>>>>
>>>>> Did you test get_maintainers.pl? MMP has a different maintainer to
>>>>> many of the other Marvell SoCs. We want emails going to the correct
>>>>> Maintainers, and ideally not spamming the others.
>>>>
>>>> The old binding was not referenced in MAINTAINERS, at least I could not
>>>> find it.
>>>> My change does not affect status quo - orphaned files.
>>>>
>>>> OTOH, some entries like Orion list specific files. Others like Marvell
>>>> list entire directory, which is their mistake in the first place.
>>>>
>>>> There is a mess in this approach, but the mess exists before my patch.
>>>
>>> I think these moved files will now match:
>>>
>>> ARM/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SOC support
>>> M:      Andrew Lunn <andrew@lunn.ch>
>>> M:      Gregory Clement <gregory.clement@bootlin.com>
>>> M:      Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>> L:      linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>>> S:      Maintained
>>> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git
>>> F:      Documentation/devicetree/bindings/arm/marvell/
>>>
>>> But these files are not Gregory or my problem.
>>
>> Yeah, that's what I meant by listing entire directory.
>>
>>>
>>> If they were orphaned before, i would prefer they are either orphaned
>>> after the move, or associated to the correct maintainer. Being
>>> associated to the wrong maintainers is worse than having no
>>> maintainers at all.
>>
>> I can add this to existing maintainers entry. Which one? I see only two
>> ARM/Marvell.
> 
> MMP SUPPORT
> R:      Lubomir Rintel <lkundrak@v3.sk>
> L:      linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S:      Odd Fixes
> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git
> F:      arch/arm/boot/dts/marvell/mmp*
> F:      arch/arm/mach-mmp/
> F:      include/linux/soc/mmp/
> 
> But you also need to modify the ARM/Marvell Kirkwood and ... so that
> it excludes these MMP files.

Let's make it then in subdirectory? There are like 20 items from
Marvell/Kirkwood, so I imagine all apply to it. At least currently they
are applying.

Best regards,
Krzysztof