From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@meta.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"djwong@kernel.org" <djwong@kernel.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] iomap: directly use logical block size
Date: Wed, 26 Oct 2022 18:06:24 +0000 [thread overview]
Message-ID: <526c5c01-3c3f-3ef0-35f7-924a6e3db134@nvidia.com> (raw)
In-Reply-To: <20221026165133.2563946-1-kbusch@meta.com>
On 10/26/2022 9:51 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
we should also change any other callers like this.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-10-26 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 16:51 Keith Busch
2022-10-26 18:06 ` Chaitanya Kulkarni [this message]
2022-10-26 18:33 ` Darrick J. Wong
2022-10-28 21:41 ` Bart Van Assche
2022-10-30 8:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526c5c01-3c3f-3ef0-35f7-924a6e3db134@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=bvanassche@acm.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®