From: "Luck, Tony" <tony.luck@intel.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Ingo Molnar <mingo@kernel.org>, Tony Luck <tony.luck@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>,
Christoph Hellwig <hch@infradead.org>,
Chen Gong <gong.chen@linux.intel.com>, X86-ML <x86@kernel.org>
Subject: [PATCH] Move cper.c from drivers/acpi/apei to drivers/firmware/efi
Date: Mon, 28 Oct 2013 11:53:53 -0700 [thread overview]
Message-ID: <526eb2c117027ea234@agluck-desk.sc.intel.com> (raw)
In-Reply-To: <20131027204648.GG1982@console-pimps.org>
cper.c contains code to decode and print "Common Platform Error Records".
Originally added under drivers/acpi/apei because the only user was in that
same directory - but now we have another consumer, and we shouldn't have
to force CONFIG_ACPI_APEI get access to this code.
Since CPER is defined in the UEFI specification - the logical home for
this code is under drivers/firmware/efi/
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
Matt: as discussed earlier on the mailing list ... just looking
for your "Acked-by" so this can go on top of the patch series in
the x86/mce branch of the tip tree that already makes a bunch of
changes to cper.c
Based on Chen Gong's original patch that moved cper.c to lib/
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 252f0e818a49..08eadb4a57cb 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -374,7 +374,9 @@ source "drivers/acpi/apei/Kconfig"
config ACPI_EXTLOG
tristate "Extended Error Log support"
- depends on X86_MCE && ACPI_APEI
+ depends on X86_MCE
+ select EFI
+ select UEFI_CPER
default n
help
Certain usages such as Predictive Failure Analysis (PFA) require
diff --git a/drivers/acpi/apei/Kconfig b/drivers/acpi/apei/Kconfig
index f0c1ce95a0ec..786294bb682c 100644
--- a/drivers/acpi/apei/Kconfig
+++ b/drivers/acpi/apei/Kconfig
@@ -2,6 +2,8 @@ config ACPI_APEI
bool "ACPI Platform Error Interface (APEI)"
select MISC_FILESYSTEMS
select PSTORE
+ select EFI
+ select UEFI_CPER
depends on X86
help
APEI allows to report errors (for example from the chipset)
diff --git a/drivers/acpi/apei/Makefile b/drivers/acpi/apei/Makefile
index d1d1bc0a4ee1..5d575a955940 100644
--- a/drivers/acpi/apei/Makefile
+++ b/drivers/acpi/apei/Makefile
@@ -3,4 +3,4 @@ obj-$(CONFIG_ACPI_APEI_GHES) += ghes.o
obj-$(CONFIG_ACPI_APEI_EINJ) += einj.o
obj-$(CONFIG_ACPI_APEI_ERST_DEBUG) += erst-dbg.o
-apei-y := apei-base.o hest.o cper.o erst.o
+apei-y := apei-base.o hest.o erst.o
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index b0fc7c79dfbb..8dfdd2a1cf12 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -36,4 +36,7 @@ config EFI_VARS_PSTORE_DEFAULT_DISABLE
backend for pstore by default. This setting can be overridden
using the efivars module's pstore_disable parameter.
+config UEFI_CPER
+ defbool n
+
endmenu
diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile
index 99245ab5a79c..9ba156d3c775 100644
--- a/drivers/firmware/efi/Makefile
+++ b/drivers/firmware/efi/Makefile
@@ -4,3 +4,4 @@
obj-y += efi.o vars.o
obj-$(CONFIG_EFI_VARS) += efivars.o
obj-$(CONFIG_EFI_VARS_PSTORE) += efi-pstore.o
+obj-$(CONFIG_UEFI_CPER) += cper.o
diff --git a/drivers/acpi/apei/cper.c b/drivers/firmware/efi/cper.c
similarity index 100%
rename from drivers/acpi/apei/cper.c
rename to drivers/firmware/efi/cper.c
next prev parent reply other threads:[~2013-10-28 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 17:56 [GIT PULL] For x86/mce ... enhanced error logs Luck, Tony
2013-10-23 17:42 ` [GIT PULLv2] " Luck, Tony
2013-10-23 18:13 ` Tony Luck
2013-10-26 10:10 ` Ingo Molnar
2013-10-26 21:34 ` Tony Luck
2013-10-26 21:36 ` Christoph Hellwig
2013-10-27 7:00 ` Ingo Molnar
2013-10-27 11:01 ` Borislav Petkov
2013-10-27 20:22 ` Matt Fleming
2013-10-27 20:34 ` Borislav Petkov
2013-10-27 20:46 ` Matt Fleming
2013-10-28 18:53 ` Luck, Tony [this message]
2013-10-28 20:35 ` [PATCH] Move cper.c from drivers/acpi/apei to drivers/firmware/efi Matt Fleming
2013-10-29 8:16 ` Ingo Molnar
2013-10-26 10:06 ` [GIT PULLv2] For x86/mce ... enhanced error logs Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526eb2c117027ea234@agluck-desk.sc.intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mingo@kernel.org \
--cc=tony.luck@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome