From: Michael Walle <michael@walle.cc>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Robert Marko" <robert.marko@sartura.hr>,
"Luka Perkov" <luka.perkov@sartura.hr>,
linux-kernel@vger.kernel.org,
"Randy Dunlap" <rdunlap@infradead.org>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Daniel Golle" <daniel@makrotopia.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"kernel test robot" <lkp@intel.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>
Subject: Re: [PATCH v9 2/7] nvmem: core: Return NULL when no nvmem layout is found
Date: Tue, 08 Aug 2023 08:38:10 +0200 [thread overview]
Message-ID: <5270b7f6e571d4016eb7018745fc0e88@walle.cc> (raw)
In-Reply-To: <20230808062932.150588-3-miquel.raynal@bootlin.com>
Am 2023-08-08 08:29, schrieb Miquel Raynal:
> Currently, of_nvmem_layout_get_container() returns NULL on error, or an
> error pointer if either CONFIG_NVMEM or CONFIG_OF is turned off. We
> should likely avoid this kind of mix for two reasons: to clarify the
> intend and anyway fix the !CONFIG_OF which will likely always if we use
> this helper somewhere else. Let's just return NULL when no layout is
> found, we don't need an error value here.
>
> Link:
> https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/
> Fixes: 266570f496b9 ("nvmem: core: introduce NVMEM layouts")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202308030002.DnSFOrMB-lkp@intel.com/
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Michael Walle <michael@walle.cc>
next prev parent reply other threads:[~2023-08-08 17:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 6:29 [PATCH v9 0/7] NVMEM cells in sysfs Miquel Raynal
2023-08-08 6:29 ` [PATCH v9 1/7] nvmem: core: Create all cells before adding the nvmem device Miquel Raynal
2023-08-08 6:37 ` Michael Walle
2023-08-08 6:56 ` Srinivas Kandagatla
2023-08-08 7:24 ` Miquel Raynal
2023-08-11 11:11 ` Srinivas Kandagatla
2023-08-11 12:11 ` Miquel Raynal
2023-08-11 12:26 ` Srinivas Kandagatla
2023-08-11 12:38 ` Miquel Raynal
2023-08-08 6:29 ` [PATCH v9 2/7] nvmem: core: Return NULL when no nvmem layout is found Miquel Raynal
2023-08-08 6:38 ` Michael Walle [this message]
2023-08-08 6:29 ` [PATCH v9 3/7] nvmem: core: Do not open-code existing functions Miquel Raynal
2023-08-08 6:41 ` Michael Walle
2023-08-08 6:29 ` [PATCH v9 4/7] nvmem: core: Notify when a new layout is registered Miquel Raynal
2023-08-08 6:29 ` [PATCH v9 5/7] nvmem: core: Rework layouts to become platform devices Miquel Raynal
2023-08-08 6:29 ` [PATCH v9 6/7] ABI: sysfs-nvmem-cells: Expose cells through sysfs Miquel Raynal
2023-08-08 6:29 ` [PATCH v9 7/7] nvmem: core: " Miquel Raynal
2023-08-14 10:01 ` (subset) [PATCH v9 0/7] NVMEM cells in sysfs Srinivas Kandagatla
2023-08-17 9:06 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5270b7f6e571d4016eb7018745fc0e88@walle.cc \
--to=michael@walle.cc \
--cc=dan.carpenter@linaro.org \
--cc=daniel@makrotopia.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luka.perkov@sartura.hr \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=rdunlap@infradead.org \
--cc=robert.marko@sartura.hr \
--cc=srinivas.kandagatla@linaro.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®