From: "Arnd Bergmann" <arnd@arndb.de>
To: "laurent.pinchart" <laurent.pinchart@ideasonboard.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Guoniu Zhou" <guoniu.zhou@nxp.com>,
"Stefan Riedmueller" <s.riedmueller@phytec.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Christian Hemp" <c.hemp@phytec.de>,
"Jacopo Mondi" <jacopo@jmondi.org>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: nxp: ignore unused suspend operations
Date: Tue, 18 Apr 2023 11:20:49 +0200 [thread overview]
Message-ID: <52721c32-1cb7-4c00-accf-314ffbc32a76@app.fastmail.com> (raw)
In-Reply-To: <20230418081959.GB30837@pendragon.ideasonboard.com>
On Tue, Apr 18, 2023, at 10:19, Laurent Pinchart wrote:
> On Tue, Apr 18, 2023 at 10:04:13AM +0200, Hans Verkuil wrote:
>> Hi Arnd,
>>
>> On 18/04/2023 09:15, Arnd Bergmann wrote:
>> > From: Arnd Bergmann <arnd@arndb.de>
>> >
>> > gcc warns about some functions being unused when CONFIG_PM is
>> > disabled:
>>
>> ???
>>
>> The Kconfig has a:
>>
>> depends on HAS_DMA && PM
>>
>> So how can this be compiled with CONFIG_PM not set?
>>
>> Am I missing something?
>
> The warning appears when CONFIG_PM_SLEEP is disabled. The pm_ptr()
> change is thus not useful, but the switch to SYSTEM_SLEEP_PM_OPS() and
> RUNTIME_PM_OPS() make a difference.
I sent a v3 now. I ended up leaving the pm_ptr() in here, based on
the recommended usage of the new macros.
Arnd
prev parent reply other threads:[~2023-04-18 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 7:15 Arnd Bergmann
2023-04-18 7:30 ` Laurent Pinchart
2023-04-18 8:04 ` Hans Verkuil
2023-04-18 8:09 ` Arnd Bergmann
2023-04-18 8:19 ` Laurent Pinchart
2023-04-18 8:23 ` Hans Verkuil
2023-04-18 9:20 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52721c32-1cb7-4c00-accf-314ffbc32a76@app.fastmail.com \
--to=arnd@arndb.de \
--cc=aisheng.dong@nxp.com \
--cc=arnd@kernel.org \
--cc=c.hemp@phytec.de \
--cc=festevam@gmail.com \
--cc=guoniu.zhou@nxp.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s.riedmueller@phytec.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®