From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C9B8C47095 for ; Mon, 7 Jun 2021 23:29:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA7DD610E5 for ; Mon, 7 Jun 2021 23:29:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230313AbhFGXa7 (ORCPT ); Mon, 7 Jun 2021 19:30:59 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:58783 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbhFGXa6 (ORCPT ); Mon, 7 Jun 2021 19:30:58 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 8BA23580533; Mon, 7 Jun 2021 19:29:06 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute2.internal (MEProxy); Mon, 07 Jun 2021 19:29:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=JeacI608ztlENt+g/Kfe0iOKdJjNDia HCrhjdIxMGDE=; b=HgSEJu9c/q8HnpLV3yCHbHIKtSQuICOrEk2tT4mVGEHDpBe Rt5XHfJmxBZSRao6WXuT6jslFlHOIWAhe9TtXjprc0a2T8YrhwAIoMrlj70r1PHG 4zPsukok5dP9eUN9ewQvnhqQkEajUbYXIA7/QdDhl3YPSHBnt+f4ZPhzFz1ibS96 xYcDHZVCyawm0m+ANkLraLmHyv0X1DCM+Gl7mQTZ7b+9heI3jx/h9BfLYnY8sxLu kTYZK6iy3bgcaySWE0BoCHYiul6yAAwKv1js1Sn/5UHq5l/UJ1taS70HI9sPjs6G le1l56VB1UHUiPsKScXW46cciKa1yHxfDU4888w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=JeacI6 08ztlENt+g/Kfe0iOKdJjNDiaHCrhjdIxMGDE=; b=B7NFnr6Z9CaPmmwhvz4tZA WTDlxEjHuE9/hKP5XB+UgGuKHCJkd+Eau5yvc/IMD/BaTtbgbEUamyrnB//WVaDP RmlgfRb6BpomRG+QL5ZRi0mucx1NBhYNCvPL+jUWngVGhm1iRKshBtIIAFr1qbss Bnp6HHBmfq05oGRKLPynHs4BWeQhQs8/AxR4+KiEm+9j8zgDPwh0l+Q8YidR5jdd dklqR5McUEGpBHl4qUthcujFsHo+7GWZU6CDwIqyTCZI+zYitAFDvV5Lw1g7LYXT +4+DnWrpDW8vealbFSm/CMSDv28GDb6/K/jZYfApE+2YNNUih29/8oJDLS0D9aGA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtkedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhephefhfeekgfekudevheffheeihedujeefjeevjeefudfgfeeutdeuvdeh hfevueffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id A3E24AC0062; Mon, 7 Jun 2021 19:29:03 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-519-g27a961944e-fm-20210531.001-g27a96194 Mime-Version: 1.0 Message-Id: <5277db96-4eb8-4794-a1fa-6a5bc40bffb7@www.fastmail.com> In-Reply-To: <20210607071514.11727-4-steven_lee@aspeedtech.com> References: <20210607071514.11727-1-steven_lee@aspeedtech.com> <20210607071514.11727-4-steven_lee@aspeedtech.com> Date: Tue, 08 Jun 2021 08:58:42 +0930 From: "Andrew Jeffery" To: "Steven Lee" , "Linus Walleij" , "Bartosz Golaszewski" , "Rob Herring" , "Joel Stanley" , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" Cc: "Hongwei Zhang" , "Ryan Chen" , "Billy Tsai" Subject: Re: [PATCH v4 3/7] ARM: dts: aspeed-g6: Add SGPIO node. Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Jun 2021, at 16:45, Steven Lee wrote: > AST2600 supports 2 SGPIO master interfaces one with 128 pins another one > with 80 pins. > > Signed-off-by: Steven Lee > --- > arch/arm/boot/dts/aspeed-g6.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index f96607b7b4e2..c09b24824b6d 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -377,6 +377,36 @@ > #interrupt-cells = <2>; > }; > > + sgpiom0: sgpiom@1e780500 { > + #gpio-cells = <2>; > + gpio-controller; > + compatible = "aspeed,ast2600-sgpiom-128"; > + reg = <0x1e780500 0x100>; > + interrupts = ; > + ngpios = <128>; Doesn't this affect the way the data is presented on the bus? My understanding is this should be defined by each platform, not in the dtsi. Having said that, it appears it is specified in aspeed-g5.dtsi (as the value 8?). > + clocks = <&syscon ASPEED_CLK_APB2>; > + interrupt-controller; > + bus-frequency = <12000000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sgpm1_default>; > + status = "disabled"; > + }; > + > + sgpiom1: sgpiom@1e780600 { > + #gpio-cells = <2>; > + gpio-controller; > + compatible = "aspeed,ast2600-sgpiom-80"; > + reg = <0x1e780600 0x100>; > + interrupts = ; > + ngpios = <80>; As above. Andrew