From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076Ab3KJTPk (ORCPT ); Sun, 10 Nov 2013 14:15:40 -0500 Received: from mail-lb0-f173.google.com ([209.85.217.173]:39097 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656Ab3KJTPa (ORCPT ); Sun, 10 Nov 2013 14:15:30 -0500 Message-ID: <527FDB50.1050902@cogentembedded.com> Date: Sun, 10 Nov 2013 23:15:28 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Michal Nazarewicz , Johannes Berg , Emmanuel Grumbach , "John W. Linville" CC: Intel Linux Wireless , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Nazarewicz Subject: Re: [PATCH] net: wireless: iwlwifi: remove minor dead code References: <1384110397-24386-1-git-send-email-mpn@google.com> In-Reply-To: <1384110397-24386-1-git-send-email-mpn@google.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 10-11-2013 23:06, Michal Nazarewicz wrote: > From: Michal Nazarewicz > inta is checked to be zero in a IRQ_NONE branch so afterwards it > cannot be zero as it is never modified. > Signed-off-by: Michal Nazarewicz > --- > drivers/net/wireless/iwlwifi/pcie/rx.c | 23 ++++++++--------------- > 1 file changed, 8 insertions(+), 15 deletions(-) > diff --git a/drivers/net/wireless/iwlwifi/pcie/rx.c b/drivers/net/wireless/iwlwifi/pcie/rx.c > index 3f237b4..c32122a 100644 > --- a/drivers/net/wireless/iwlwifi/pcie/rx.c > +++ b/drivers/net/wireless/iwlwifi/pcie/rx.c [...] > @@ -1150,7 +1149,13 @@ static irqreturn_t iwl_pcie_isr(int irq, void *data) > * or due to sporadic interrupts thrown from our NIC. */ > if (!inta) { > IWL_DEBUG_ISR(trans, "Ignore interrupt, inta == 0\n"); > - goto none; > + /* re-enable interrupts here since we don't have anything to > + * service. only Re-enable if disabled by irq and no > + * schedules tasklet. */ The preferred way of formatting the multi-line comments in the networking code is this: /* bla * bla */ WBR, Sergei