From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753936Ab3KKNdV (ORCPT ); Mon, 11 Nov 2013 08:33:21 -0500 Received: from nat28.tlf.novell.com ([130.57.49.28]:53457 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753515Ab3KKNdN convert rfc822-to-8bit (ORCPT ); Mon, 11 Nov 2013 08:33:13 -0500 Message-Id: <5280EAA40200007800101DF1@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.2 Date: Mon, 11 Nov 2013 13:33:08 +0000 From: "Jan Beulich" To: "Kyungsik Lee" Cc: "Matthew Daley" , , , , Subject: Re: [PATCH] unlz4: always set an error return code on failures References: <527CBC7D020000780010117C@nat28.tlf.novell.com> <20131111024924.GA23164@hulk> <5280A4E30200007800101A2C@nat28.tlf.novell.com> <20131111130227.GA31739@hulk> In-Reply-To: <20131111130227.GA31739@hulk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 11.11.13 at 14:02, Kyungsik Lee wrote: > On Mon, Nov 11, 2013 at 08:35:31AM +0000, Jan Beulich wrote: >> >>> On 11.11.13 at 03:49, Kyungsik Lee wrote: >> > Hello Jan, >> > >> > Thanks for the patch. >> > >> > On Fri, Nov 08, 2013 at 09:27:09AM +0000, Jan Beulich wrote: >> >> "ret", being set to -1 early on, gets cleared by the first invocation >> >> of lz4_decompress()/lz4_decompress_unknownoutputsize(), and hence >> >> subsequent failures wouldn't be noticed by the caller without setting >> >> it back to -1 right after those calls. >> >> >> >> Reported-by: Matthew Daley >> >> Signed-off-by: Jan Beulich >> >> Cc: Kyungsik Lee >> >> Cc: Andrew Morton >> >> >> >> --- a/lib/decompress_unlz4.c >> >> +++ b/lib/decompress_unlz4.c >> >> @@ -141,6 +141,7 @@ STATIC inline int INIT unlz4(u8 *input, >> >> goto exit_2; >> >> } >> >> >> >> + ret = -1; >> >> if (flush && flush(outp, dest_len) != dest_len) >> >> goto exit_2; >> >> if (output) >> >> >> > What do you think of adding "ret2" for keeping "ret" error status >> > which is set by lz4_decompress*() like below. >> >> I'd be fine with that too, but preferred to submit the smallest >> possible (read: one line) patch in this case. >> > I think it looks neat avoiding "ret" being set to error status > in the loop. Can you please resend the patch with those changes? I'm sorry, I'm confused - on one hand you're asking for changes (which I'm not going to do - I proposed the patch as is, and am not going to put my name under one that's introducing ugliness like "ret2"), ... > Acked-by: Kyungsik Lee ... yet then you give your ack to the existing patch. Jan