From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754622Ab3KKQ2K (ORCPT ); Mon, 11 Nov 2013 11:28:10 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:54137 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694Ab3KKQ2C (ORCPT ); Mon, 11 Nov 2013 11:28:02 -0500 Message-ID: <5281058E.5050607@wwwdotorg.org> Date: Mon, 11 Nov 2013 09:27:58 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Felipe Balbi , mturquette@linaro.org CC: Linux ARM Kernel Mailing List , Linux OMAP Mailing List , Linux Kernel Mailing List , james.hogan@imgtec.com, luca@coelho.fi Subject: Re: [PATCH] clk: add flags to distinguish xtal clocks References: <1382528150.21526.25.camel@porter.coelho.fi> <1383933648-28595-1-git-send-email-balbi@ti.com> In-Reply-To: <1383933648-28595-1-git-send-email-balbi@ti.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2013 11:00 AM, Felipe Balbi wrote: > From: Luciano Coelho > > Add a flag that indicate whether the clock is a crystal or not. > > Additionally, parse a new device tree binding in clk-fixed-rate to set > this flag. > > If clock-xtal isn't set, the clock framework will assume clock to be > generated by an oscillator. There's only one user for this binding > right now which is Texas Instruments' WiLink devices which need to know > details about the clock in order to initialize the underlying WiFi HW > correctly. Why on earth does it care? Surely the WiFi HW doesn't care about crystal-vs-non-crystal, but rather some facet of the clock signal that the type of source implies. Shouldn't the DT property describe that facet of the signal, rather than the reason why it has that facet?