mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Pekka Enberg <penberg@kernel.org>, linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] perf trace: Fix syscall summary duration order
Date: Tue, 12 Nov 2013 07:15:28 -0700	[thread overview]
Message-ID: <52823800.3020608@gmail.com> (raw)
In-Reply-To: <1384265410-12344-1-git-send-email-penberg@kernel.org>

On 11/12/13, 7:10 AM, Pekka Enberg wrote:
> Switch duration order to minimum, average, maximum for the '--summary'
> command line option because it's more natural to read.
>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Signed-off-by: Pekka Enberg <penberg@kernel.org>
> ---
>   tools/perf/builtin-trace.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

I would change the 'Fix' in the summary line to 'Change'. Other than that...

Acked-by: David Ahern <dsahern@gmail.com>


  reply	other threads:[~2013-11-12 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 14:10 Pekka Enberg
2013-11-12 14:15 ` David Ahern [this message]
2013-11-12 21:56 ` [tip:perf/urgent] perf trace: Change " tip-bot for Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52823800.3020608@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome