From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755937Ab3KLPxg (ORCPT ); Tue, 12 Nov 2013 10:53:36 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:49255 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753098Ab3KLPxe (ORCPT ); Tue, 12 Nov 2013 10:53:34 -0500 Message-ID: <52824ED9.5040104@ti.com> Date: Tue, 12 Nov 2013 10:52:57 -0500 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: "Khoronzhuk, Ivan" CC: Rob Landley , Russell King , "devicetree@vger.kernel.org" , Pawel Moll , Mark Rutland , Rob Herring , Stephen Warren , Kumar Gala , Ian Campbell , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mtd@lists.infradead.org" , "Strashko, Grygorii" Subject: Re: [PATCH 03/12] mtd: nand: davinci: simplify error handling References: <1384187188-5776-1-git-send-email-ivan.khoronzhuk@ti.com>,<1384187188-5776-4-git-send-email-ivan.khoronzhuk@ti.com> <4F5844B3A985794BA902E12C070812375F8CFB@DNCE04.ent.ti.com> In-Reply-To: <4F5844B3A985794BA902E12C070812375F8CFB@DNCE04.ent.ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 11 November 2013 11:54 AM, Khoronzhuk, Ivan wrote: > There is not needed to use a lot of names for err handling. > It complicates code support and reading. > This is not always true but looking at the patch, the labels are just useless since no special handling per label. > Signed-off-by: Ivan Khoronzhuk > --- Acked-by: Santosh Shilimkar