From: Hans de Goede <hdegoede@redhat.com>
To: "Markus Elfring" <Markus.Elfring@web.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Harshit Mogalapalli" <harshit.m.mogalapalli@oracle.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Zhang Rui" <rui.zhang@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [v2] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()
Date: Mon, 20 May 2024 19:49:14 +0200 [thread overview]
Message-ID: <5287fc2e-91c5-442b-b66c-6eb1fe334ce4@redhat.com> (raw)
In-Reply-To: <d73fe99b-dea3-4792-aa1c-c3317f296003@web.de>
Hi Markus,
On 5/20/24 12:56 PM, Markus Elfring wrote:
>>> …
>>>> Fix this by reordering the kfree() post the dereference.
>>>
>>> Would a wording approach (like the following) be a bit nicer?
>>>
>>> Move a kfree() call behind an assignment statement in the affected if branch.
>>
>> No, the suggested wording would make it less precise ("post the
>> dereference" -> "behind an assignment") and also tries to tell pointless
>> things about the location in the codei that is visible in the patch itself.
>
> Would you eventually like another wording variant a bit more?
>
> Thus move a kfree() call behind a dereference of an invalid pointer.
The original wording of the commit message really is fine as is,
I see no need for Harshit to send a new version and I plan to
merge this as is.
Regards,
Hans
next prev parent reply other threads:[~2024-05-20 17:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 14:49 [PATCH v2] " Harshit Mogalapalli
2024-05-17 15:15 ` srinivas pandruvada
2024-05-18 17:30 ` Markus Elfring
2024-05-20 9:38 ` Ilpo Järvinen
2024-05-20 10:56 ` [v2] " Markus Elfring
2024-05-20 17:49 ` Hans de Goede [this message]
2024-05-21 5:15 ` Markus Elfring
2024-05-21 10:06 ` Ilpo Järvinen
2024-05-21 10:42 ` Markus Elfring
2024-05-21 10:56 ` Ilpo Järvinen
2024-05-21 11:09 ` Markus Elfring
2024-05-27 9:29 ` [PATCH v2] " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5287fc2e-91c5-442b-b66c-6eb1fe334ce4@redhat.com \
--to=hdegoede@redhat.com \
--cc=Markus.Elfring@web.de \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®