From: Lan Tianyu <tianyu.lan@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Patch Tracking <patches@linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nishanth Menon <nm@ti.com>,
jinchoi@broadcom.com,
Sebastian Capella <sebastian.capella@linaro.org>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Subject: Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers
Date: Mon, 18 Nov 2013 21:37:39 +0800 [thread overview]
Message-ID: <528A1823.8080705@intel.com> (raw)
In-Reply-To: <CAKohpo=UjSqzE+Jg0s3taykHu4VinNUvLLhRm6pUXiyUc5F-3w@mail.gmail.com>
On 11/18/2013 07:01 PM, Viresh Kumar wrote:
> On 18 November 2013 16:27, Lan Tianyu <tianyu.lan@intel.com> wrote:
>> How about introducing a resume/suspend callback pointer or list(if there
>> are several places that need to deal with cpu resume/suspend) in the
>> struct cpu and populate it in the cpufreq_add_dev()?
>>
>> The suspend/resume() of cpu_subsys needs to check the callback pointer
>> and run it if available.
>
> That's almost a new infrastructure then and looks more hackish :)
The resume/suspend() must be stored in the struct driver->pm? :)
> Apart from that even cpufreq would be a bit hacky as we don't really need
> per-cpu callbacks..
>
This maybe depends on where we want the issue to be fixed, right?
The cpufreq driver also can fix the issue if we run their cpu_driver
resume/suspend callback earlier.
Another point, I just see cpuidle_resume() and cpuidle_pause() are
called in the dpm_resume_noirq and dpm_suspend_noirq(). Not sure whether
this can be applied to cpufreq.
--
Best Regards
Tianyu Lan
next prev parent reply other threads:[~2013-11-18 13:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 10:12 Viresh Kumar
2013-11-15 13:48 ` Nishanth Menon
2013-11-15 15:34 ` Viresh Kumar
2013-11-16 0:24 ` Rafael J. Wysocki
2013-11-16 4:31 ` viresh kumar
2013-11-16 14:29 ` Rafael J. Wysocki
2013-11-16 15:17 ` Viresh Kumar
2013-11-17 1:08 ` Rafael J. Wysocki
2013-11-17 8:22 ` viresh kumar
2013-11-17 15:09 ` Rafael J. Wysocki
2013-11-17 16:57 ` Viresh Kumar
2013-11-17 21:37 ` Rafael J. Wysocki
2013-11-18 5:39 ` viresh kumar
2013-11-18 10:57 ` Lan Tianyu
2013-11-18 11:01 ` Viresh Kumar
2013-11-18 13:37 ` Lan Tianyu [this message]
2013-11-18 15:32 ` Viresh Kumar
2013-11-21 14:39 ` Rafael J. Wysocki
2013-11-20 5:34 ` Viresh Kumar
2013-11-21 1:07 ` Rafael J. Wysocki
2013-11-21 14:38 ` Rafael J. Wysocki
2013-11-21 16:17 ` Viresh Kumar
2013-11-21 22:14 ` Rafael J. Wysocki
2013-11-22 9:11 ` viresh kumar
2013-11-25 4:25 ` Viresh Kumar
2013-11-25 11:35 ` Rafael J. Wysocki
2013-12-25 22:39 ` Pavel Machek
2013-12-26 0:56 ` Rafael J. Wysocki
2013-11-16 5:56 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A1823.8080705@intel.com \
--to=tianyu.lan@intel.com \
--cc=cpufreq@vger.kernel.org \
--cc=jinchoi@broadcom.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=sebastian.capella@linaro.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®