From: Li Zefan <lizefan@huawei.com>
To: Shawn Bohrer <shawn.bohrer@gmail.com>
Cc: Hugh Dickins <hughd@google.com>, Tejun Heo <tj@kernel.org>,
Michal Hocko <mhocko@suse.cz>, <cgroups@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Markus Blank-Burian <burian@muenster.de>
Subject: Re: 3.10.16 cgroup_mutex deadlock
Date: Tue, 19 Nov 2013 10:55:18 +0800 [thread overview]
Message-ID: <528AD316.10001@huawei.com> (raw)
In-Reply-To: <20131118201025.GA2747@sbohrermbp13-local.rgmadvisors.com>
> Thanks Tejun and Hugh. Sorry for my late entry in getting around to
> testing this fix. On the surface it sounds correct however I'd like to
> test this on top of 3.10.* since that is what we'll likely be running.
> I've tried to apply Hugh's patch above on top of 3.10.19 but it
> appears there are a number of conflicts. Looking over the changes and
> my understanding of the problem I believe on 3.10 only the
> cgroup_free_fn needs to be run in a separate workqueue. Below is the
> patch I've applied on top of 3.10.19, which I'm about to start
> testing. If it looks like I botched the backport in any way please
> let me know so I can test a propper fix on top of 3.10.19.
>
You didn't move css free_work to the dedicate wq as Tejun's patch does.
css free_work won't acquire cgroup_mutex, but when destroying a lot of
cgroups, we can have a lot of css free_work in the workqueue, so I'd
suggest you also use cgroup_destroy_wq for it.
next prev parent reply other threads:[~2013-11-19 2:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 22:06 Shawn Bohrer
2013-11-12 10:17 ` Li Zefan
2013-11-12 14:31 ` Michal Hocko
2013-11-12 15:55 ` Shawn Bohrer
2013-11-12 16:55 ` Michal Hocko
2013-11-14 22:56 ` Shawn Bohrer
2013-11-15 6:24 ` Tejun Heo
2013-11-15 7:54 ` Tejun Heo
2013-11-18 2:17 ` Hugh Dickins
2013-11-18 20:10 ` Shawn Bohrer
2013-11-19 2:55 ` Li Zefan [this message]
2013-11-20 22:47 ` Shawn Bohrer
2013-11-22 20:59 ` William Dauchy
2013-11-22 22:18 ` Tejun Heo
2013-11-22 22:54 ` William Dauchy
2013-11-25 1:20 ` Li Zefan
2013-12-02 10:31 ` William Dauchy
2013-12-03 1:37 ` Li Zefan
2013-11-22 22:17 ` [PATCH cgroup/for-3.13-fixes] cgroup: use a dedicated workqueue for cgroup destruction Tejun Heo
2013-11-24 18:23 ` Hugh Dickins
2013-11-25 1:16 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528AD316.10001@huawei.com \
--to=lizefan@huawei.com \
--cc=burian@muenster.de \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=shawn.bohrer@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome