From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>, Joe Perches <joe@perches.com>
Cc: "Ingo Molnar" <mingo@kernel.org>,
"Johannes Löthberg" <johannes@kyriasis.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: boot: Fix mixed indentation in a20.c
Date: Tue, 19 Nov 2013 10:24:11 -0800 [thread overview]
Message-ID: <528BACCB.1090604@zytor.com> (raw)
In-Reply-To: <20131119182306.GD3515@pd.tnic>
On 11/19/2013 10:23 AM, Borislav Petkov wrote:
> On Tue, Nov 19, 2013 at 09:48:43AM -0800, Joe Perches wrote:
>> git diff -w and git blame -w both ignore whitespace changes and can
>> help in tracking down actual modifications.
>
> That's not the point - I don't want those commits there getting in the
> way.
>
> If it
>
> * doesn't fix a real bug,
> * doesn't improve code generation
> * doesn't have any other positive effect on the resulting object code
>
> then it doesn't need to be there.
>
> Whitespace jerking off doesn't belong in the kernel.
>
I'll take a proper cleanup, but just whitespace... just pointless churn.
-hpa
next prev parent reply other threads:[~2013-11-19 18:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 17:50 Johannes Löthberg
2013-11-19 2:22 ` H. Peter Anvin
2013-11-19 7:22 ` Ingo Molnar
2013-11-19 10:34 ` Borislav Petkov
2013-11-19 17:48 ` Joe Perches
2013-11-19 18:23 ` Borislav Petkov
2013-11-19 18:24 ` H. Peter Anvin [this message]
2013-11-19 18:28 ` Joe Perches
2013-11-19 18:45 ` H. Peter Anvin
2013-11-19 18:59 ` Borislav Petkov
2013-11-25 10:18 ` Ingo Molnar
2013-11-25 11:02 ` Borislav Petkov
2013-11-26 0:51 ` Joe Perches
2013-11-26 7:43 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528BACCB.1090604@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=joe@perches.com \
--cc=johannes@kyriasis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome