From: Bob Liu <bob.liu@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Bob Liu <lliubbo@gmail.com>,
ian.campbell@citrix.com, xen-devel@lists.xenproject.org,
konrad.wilk@oracle.com, linux-kernel@vger.kernel.org,
keir@xen.org
Subject: Re: [PATCH] xen: tmem: rmove useless parameters
Date: Wed, 20 Nov 2013 17:22:19 +0800 [thread overview]
Message-ID: <528C7F4B.3050802@oracle.com> (raw)
In-Reply-To: <528C8A980200007800104E69@nat28.tlf.novell.com>
On 11/20/2013 05:10 PM, Jan Beulich wrote:
>>>> On 20.11.13 at 09:52, Bob Liu <lliubbo@gmail.com> wrote:
>> @@ -100,9 +100,6 @@ static inline int xen_tmem_op(u32 tmem_cmd, u32 tmem_pool, struct tmem_oid oid,
>> op.u.gen.oid[1] = oid.oid[1];
>> op.u.gen.oid[2] = oid.oid[2];
>> op.u.gen.index = index;
>> - op.u.gen.tmem_offset = tmem_offset;
>> - op.u.gen.pfn_offset = pfn_offset;
>> - op.u.gen.len = len;
>
> But you can't leave these fields uninitialized.
>
Oh, yes.
And I should remove those members totally from struct tmem_op {}
--
Thanks,
-Bob
next prev parent reply other threads:[~2013-11-20 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 8:52 Bob Liu
2013-11-20 9:10 ` Jan Beulich
2013-11-20 9:22 ` Bob Liu [this message]
2013-11-20 9:26 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528C7F4B.3050802@oracle.com \
--to=bob.liu@oracle.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lliubbo@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®