From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753961Ab3KUM25 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Nov 2013 07:28:57 -0500
Received: from mail-ea0-f181.google.com ([209.85.215.181]:43397 "EHLO
	mail-ea0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751154Ab3KUM2z (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Nov 2013 07:28:55 -0500
Message-ID: <528DFC81.2070000@gmail.com>
Date: Thu, 21 Nov 2013 13:28:49 +0100
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0
To: Alan Tull <delicious.quinoa@gmail.com>, linux-kernel@vger.kernel.org
CC: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@stericsson.com>,
        linux-doc@vger.kernel.org,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Grant Likely <grant.likely@secretlab.ca>,
        Rob Herring <rob.herring@calxeda.com>,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        Jamie Iles <jamie@jamieiles.com>, Heiko Stuebner <heiko@sntech.de>,
        Alan Tull <atull@altera.com>, Dinh Nguyen <dinguyen@altera.com>,
        Yves Vandervennet <rocket.yvanderv@gmail.com>
Subject: Re: [PATCH v7] gpio: add a driver for the Synopsys DesignWare APB
 GPIO block
References: <1384984090-6772-1-git-send-email-delicious.quinoa@gmail.com>
In-Reply-To: <1384984090-6772-1-git-send-email-delicious.quinoa@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/20/2013 10:48 PM, Alan Tull wrote:
> From: Jamie Iles <jamie@jamieiles.com>
>
> The Synopsys DesignWare block is used in some ARM devices (picoxcell)
> and can be configured to provide multiple banks of GPIO pins.
>
> Signed-off-by: Alan Tull <atull@altera.com>

Alan,

I haven't looked as close as in the last reviews, but I think it is
fine to have this version as a start. We can add platform_data and
CONFIG_REG parsing later.

Thanks for the patience, you can add my

Reviewed-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>