From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755849Ab3KVQVL (ORCPT ); Fri, 22 Nov 2013 11:21:11 -0500 Received: from www.linutronix.de ([62.245.132.108]:45863 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755688Ab3KVQVI (ORCPT ); Fri, 22 Nov 2013 11:21:08 -0500 Message-ID: <528F846E.4000703@linutronix.de> Date: Fri, 22 Nov 2013 17:21:02 +0100 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Peter Zijlstra CC: Thomas Gleixner , Mike Galbraith , Frederic Weisbecker , LKML , RT , "Paul E. McKenney" Subject: Re: [PATCH v2] rtmutex: take the waiter lock with irqs off References: <1383798668.5441.25.camel@marge.simpson.net> <20131107125923.GB24644@localhost.localdomain> <1384243595.15180.63.camel@marge.simpson.net> <20131115163008.GB12164@linutronix.de> <20131115201436.GC12164@linutronix.de> <20131118141021.GA10022@twins.programming.kicks-ass.net> <20131122135931.GA8698@linutronix.de> <20131122160841.GS3866@twins.programming.kicks-ass.net> In-Reply-To: <20131122160841.GS3866@twins.programming.kicks-ass.net> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/2013 05:08 PM, Peter Zijlstra wrote: > On Fri, Nov 22, 2013 at 02:59:31PM +0100, Sebastian Andrzej Siewior wrote: >> +extern void __lockfunc rt_spin_try_unlock(spinlock_t *lock); > > I know what you mean, but.. try_unlock() just sounds wrong, how can we > attempt but fail to unlock a lock we hold ;-) what about - rt_spin_unlock_try_or_fail(); - __rt_spin_unlock_dont_use_me() Couldn't we tell lockdep to bend the rules in this case? > > > /me crawls back under his rock ;-) :) Sebastian