From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755212AbdLTMDF (ORCPT ); Wed, 20 Dec 2017 07:03:05 -0500 Received: from mout.web.de ([217.72.192.78]:54732 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755060AbdLTMDB (ORCPT ); Wed, 20 Dec 2017 07:03:01 -0500 Subject: [PATCH 2/2] pinctrl: adi2: Improve a size determination in two functions From: SF Markus Elfring To: linux-gpio@vger.kernel.org, Linus Walleij , Sonic Zhang Cc: LKML , kernel-janitors@vger.kernel.org References: <3d620bed-db19-aacd-0ea5-4c64aee104d1@users.sourceforge.net> Message-ID: <528bd747-ad86-8480-f4f7-b8689448b336@users.sourceforge.net> Date: Wed, 20 Dec 2017 13:02:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <3d620bed-db19-aacd-0ea5-4c64aee104d1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:I4G/RPE739V1ADPN3MryWzX66x93cuNxeXwg5YKwYPo5kaEeJtc PVkMtAgB01bd3bDXxvbtPlICgRQsVtogA733YH60oN+0WYxdN5SBD1r57HkD+o0sk45qiEP DcLjlq8fAwmnRI7vTu793yRBXfA1NWr/WJ8RtqgMhcjac+ComMPS/D1piN/SMbzHkeLEhaX X32BlK9yz9TqMc4sQtKPw== X-UI-Out-Filterresults: notjunk:1;V01:K0:A8yoEOMs5Tc=:SmmU+ggXuPHbRtjigRywWW qAkCHvKhd6TxlHcwpWwwIcKZ7gN3yUso7VmlA89iBLqCKZtSvRIJp0S4mlscggJB8o4wngJJW amgQ61zky9tJ8WCwIMuoeboqk8VY/gqEraBKbZiwHjkY3RY35om0DDj1CfzAhxeAwV8TpOdo+ 7N4/CUvr4g2U5dfquYmPueRwPPzCVBaiXAmjb+0KSDj19jJRv6dK1eWdG29XDh8IxqGQtkm5d 8QrD/0D3QVKoJKjDozaF3U16sZnLH2jgEZzVnBy63DtuB1l41TAiuNc+SpNC1F5u2LbLT7fkk dSw7KIyzZ9bSeMPkWKy3nXv0guZlCXAitnl0LWWfVvLKxc20MLDMFEeGu5fshTMFiYeMRUi36 xFgRvom6YtGWHIbVj2KfwP3jcxmlkCnRgiqDrjMp5czY/8GzVmwC7Sg4UkmPvZZkJpSttGVYS +kvGYh0AoASmGLZMl9df8ToeGb76t6xwrdCwUL/ceH2E8T8rDVcgo9yyieTz5XYU+kZkaT6XV J88Pygr9hNVFLakbiIVjqhJ7mSbOrbGzj/JGhZN9CC46f7van5V6plFc+i3H10mGue6UWVCyr WIrGMzFV745WNKmF2N6oBlCgeVqRTCfOT5Jid0wbFZmQUlDyXPqUZdE3WyiTZxy+GajfLq010 7pxBFmWxGeAjuJsRNQSxr9QfDuTTijFOnxKuLbEM/SWk7UKswPxKZMgCWAzjsE3n6lG4s2Ct9 +YWG1PAsrtc/DZlzACagMCe6lLhHn610XrQMACWBU185QQbntLtuF1j2T7/xa5OdIecyKnlDk 66Ra3w463oOh1K8kn3OyR0Qcr2E9k5OMIzmJ6DfYV2mva0gKTw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 20 Dec 2017 12:38:53 +0100 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinctrl-adi2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c index aefaf5855089..094a451db2a2 100644 --- a/drivers/pinctrl/pinctrl-adi2.c +++ b/drivers/pinctrl/pinctrl-adi2.c @@ -827,9 +827,8 @@ static int adi_gpio_pint_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct resource *res; - struct gpio_pint *pint; + struct gpio_pint *pint = devm_kzalloc(dev, sizeof(*pint), GFP_KERNEL); - pint = devm_kzalloc(dev, sizeof(struct gpio_pint), GFP_KERNEL); if (!pint) return -ENOMEM; @@ -943,7 +942,7 @@ static int adi_gpio_probe(struct platform_device *pdev) if (!pdata) return -EINVAL; - port = devm_kzalloc(dev, sizeof(struct gpio_port), GFP_KERNEL); + port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL); if (!port) return -ENOMEM; -- 2.15.1