From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933349AbdEWLOh (ORCPT ); Tue, 23 May 2017 07:14:37 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56702 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760175AbdEWLOf (ORCPT ); Tue, 23 May 2017 07:14:35 -0400 Subject: Re: [PATCH] mm: Define KB, MB, GB, TB in core VM To: Andrew Morton , Anshuman Khandual References: <20170522111742.29433-1-khandual@linux.vnet.ibm.com> <20170522141149.9ef84bb0713769f4af0383f0@linux-foundation.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Anshuman Khandual Date: Tue, 23 May 2017 16:43:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170522141149.9ef84bb0713769f4af0383f0@linux-foundation.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17052311-0048-0000-0000-00000231A983 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17052311-0049-0000-0000-000047E0583B Message-Id: <528d791b-dda4-26f2-f604-f27c645b9011@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-23_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705230058 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/23/2017 02:41 AM, Andrew Morton wrote: > On Mon, 22 May 2017 16:47:42 +0530 Anshuman Khandual wrote: > >> There are many places where we define size either left shifting integers >> or multiplying 1024s without any generic definition to fall back on. But >> there are couples of (powerpc and lz4) attempts to define these standard >> memory sizes. Lets move these definitions to core VM to make sure that >> all new usage come from these definitions eventually standardizing it >> across all places. > Grep further - there are many more definitions and some may now > generate warnings. Yeah, warning reports started coming in. Will try to change all of those to follow the new definitions added.