From: Tzungder Lin <tzungder@gmail.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.29.1 1/1] 8139too: fix HW initial flow
Date: Mon, 20 Apr 2009 09:54:10 +0800 [thread overview]
Message-ID: <528f811a0904191854o3a354e8fif6a8d65f8da94965@mail.gmail.com> (raw)
In-Reply-To: <528f811a0904190316v22621684o3047e37bf8e78bda@mail.gmail.com>
From: Jonathan Lin <tzungder@gmail.com>
While ifconfig eth0 up kernel calls open() of 8139 driver(8139too.c).
In rtl8139_hw_start() of rtl8139_open(), 8139 driver enable RX before
setting up the DMA buffer address. In this interval where RX was
enabled and DMA buffer address is not yet set up, any incoming
broadcast packet would be send to a strange physical address:
0x003e8800 which is the default value of DMA buffer address.
Unfortunately, this address is used by Linux kernel. So kernel panics.
This patch fix it by setting up DMA buffer address before RX enabled
and everything is fine even under broadcast packets attack.
Signed-off-by: Jonathan Lin <tzungder@gmail.com>
--- linux-2.6.29.1/drivers/net/8139too.c.orig 2009-04-19
17:50:38.000000000 +0800
+++ linux-2.6.29.1/drivers/net/8139too.c 2009-04-19
17:52:51.000000000 +0800
@@ -1382,6 +1382,10 @@ static void rtl8139_hw_start (struct net
RTL_W32_F (MAC0 + 0, le32_to_cpu (*(__le32 *) (dev->dev_addr + 0)));
RTL_W32_F (MAC0 + 4, le16_to_cpu (*(__le16 *) (dev->dev_addr + 4)));
+ tp->cur_rx = 0;
+ /* init Rx ring buffer DMA address BEFORE Rx enabled*/
+ RTL_W32_F (RxBuf, tp->rx_ring_dma);
+
/* Must enable Tx/Rx before setting transfer thresholds! */
RTL_W8 (ChipCmd, CmdRxEnb | CmdTxEnb);
@@ -1389,8 +1393,6 @@ static void rtl8139_hw_start (struct net
RTL_W32 (RxConfig, tp->rx_config);
RTL_W32 (TxConfig, rtl8139_tx_config);
- tp->cur_rx = 0;
-
rtl_check_media (dev, 1);
if (tp->chipset >= CH_8139B) {
@@ -1405,9 +1407,6 @@ static void rtl8139_hw_start (struct net
/* Lock Config[01234] and BMCR register writes */
RTL_W8 (Cfg9346, Cfg9346_Lock);
- /* init Rx ring buffer DMA address */
- RTL_W32_F (RxBuf, tp->rx_ring_dma);
-
/* init Tx buffer DMA addresses */
for (i = 0; i < NUM_TX_DESC; i++)
RTL_W32_F (TxAddr0 + (i * 4), tp->tx_bufs_dma + (tp->tx_buf[i] -
tp->tx_bufs));
next prev parent reply other threads:[~2009-04-20 1:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 10:16 Tzungder Lin
2009-04-19 11:22 ` Eric Dumazet
2009-04-20 1:54 ` Tzungder Lin [this message]
2009-04-20 10:14 ` David Miller
2009-04-20 12:58 jon.lin
2009-04-20 13:28 ` Amos Kong
2009-04-21 8:52 ` David Miller
2009-04-21 9:48 ` Amos Kong
2009-04-21 10:09 ` jon.lin
2009-04-21 10:34 ` Eric Dumazet
2009-04-21 10:30 ` Eric Dumazet
2009-04-22 7:44 ` David Miller
2009-04-21 10:13 [PATCH 2.6.29.1 1/1]8139too:fix " User Tzungder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528f811a0904191854o3a354e8fif6a8d65f8da94965@mail.gmail.com \
--to=tzungder@gmail.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®