From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754303Ab3KZHP5 (ORCPT ); Tue, 26 Nov 2013 02:15:57 -0500 Received: from nat28.tlf.novell.com ([130.57.49.28]:39133 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085Ab3KZHP4 convert rfc822-to-8bit (ORCPT ); Tue, 26 Nov 2013 02:15:56 -0500 Message-Id: <529458B50200007800106F76@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.2 Date: Tue, 26 Nov 2013 07:15:49 +0000 From: "Jan Beulich" To: "Andrew Morton" Cc: , , , Subject: Re: [PATCH] procfs: also fix proc_reg_get_unmapped_area() for !MMU case References: <529387570200007800106C9F@nat28.tlf.novell.com> <20131125141328.d9da16e10526e2ff1d368f0f@linux-foundation.org> In-Reply-To: <20131125141328.d9da16e10526e2ff1d368f0f@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 25.11.13 at 23:13, Andrew Morton wrote: > On Mon, 25 Nov 2013 16:22:31 +0000 "Jan Beulich" wrote: > >> Commit fad1a86e ("procfs: call default get_unmapped_area on MMU-present >> architectures"), as its title says, took care of only the MMU case, >> leaving the !MMU side still in the regressed state (returning -EIO in >> all cases where pde->proc_fops->get_unmapped_area is NULL). > > The changelog is rather mystifying unless the reader goes off and finds > the fad1a86e changelog, so let's do that for them by adding this: > > From the fad1a86e changelog: > > : Commit c4fe24485729 ("sparc: fix PCI device proc file mmap(2)") added > : proc_reg_get_unmapped_area in proc_reg_file_ops and > : proc_reg_file_ops_no_compat, by which now mmap always returns EIO if > : get_unmapped_area method is not defined for the target procfs file, which > : causes regression of mmap on /proc/vmcore. > : > : To address this issue, like get_unmapped_area(), call default > : current->mm->get_unmapped_area on MMU-present architectures if > : pde->proc_fops->get_unmapped_area, i.e. the one in actual file operation > : in the procfs file, is not defined. > >> Signed-off-by: Jan Beulich >> Cc: HATAYAMA Daisuke >> Cc: Alexey Dobriyan >> Cc: David S. Miller > > I tagged this with > > Cc: [3.12.x] > > OK? Sure. I also see you didn't like the way I coded it, and put a code restructuring patch on top... Jan