From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758310Ab3KZWgN (ORCPT ); Tue, 26 Nov 2013 17:36:13 -0500 Received: from mms1.broadcom.com ([216.31.210.17]:4366 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758190Ab3KZWgJ (ORCPT ); Tue, 26 Nov 2013 17:36:09 -0500 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Message-ID: <52952248.6060700@broadcom.com> Date: Tue, 26 Nov 2013 14:35:52 -0800 From: "Ray Jui" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: "Chris Ball" cc: "Seungwon Jeon" , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH v2] mmc: fix host release issue after discard operation References: <1382810624-17659-1-git-send-email-rjui@broadcom.com> <87fvqig6nl.fsf@octavius.laptop.org> In-Reply-To: <87fvqig6nl.fsf@octavius.laptop.org> X-WSS-ID: 7E8BFDB515011562872-01-01 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/26/2013 2:06 PM, Chris Ball wrote: > Hi Ray, > > On Sat, Oct 26 2013, Ray Jui wrote: >> Under function mmc_blk_issue_rq, after an MMC discard operation, >> the MMC request data structure may be freed in memory. Later in >> the same function, the check of req->cmd_flags & MMC_REQ_SPECIAL_MASK >> is dangerous and invalid. It causes the MMC host not to be released >> when it should >> >> This patch fixes the issue by marking the special request down before >> the discard/flush operation >> >> Reported by: Harold (SoonYeal) Yang >> Signed-off-by: Ray Jui >> Reviewed-by: Seungwon Jeon > > Thanks, pushed to mmc-next for 3.14 and -stable. > > - Chris. > Great! Thanks, Ray