From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFF90241139 for ; Mon, 16 Mar 2026 11:03:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659033; cv=none; b=SoSC7BnpeCMsT0MU2gIqskvaZlKFEa1bHjb1VOQEWqK7iANN6oWQcvZiu7a42gBZlpQYuVUdzVSaFGQEFSnAhGQSmM6UgfE/NN3VtQEkfU1L/tLjPKL3TrBtvfUOJCfB7HJhYYAZTcWMcsIiYdKwWLfr6QPgFCMkms06Sh6AMys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659033; c=relaxed/simple; bh=ONDlb32qfrMTx81xQ6xuub1GdI9oAvu0FzssNJPtv6M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bgTIRtQmZvTs05ebiLZJ+I5d79N8UUM2ACuRQBpTKVjbu8tRsq2l5VzOdIGUvErMkYCYTjbFUtKbHMyl0cSeAyYsy7F/aCTGYnVAY7uz4RruR2fUgp4Y9WpXDXk6NKaXhae/T/KGCo8XLbbkQWU2cY8lKnE23ocjYFikdRkXlig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lvbbAm3C; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jljJdOFE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lvbbAm3C"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jljJdOFE" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G7n2Ie041951 for ; Mon, 16 Mar 2026 11:03:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IKvEpj8o9w79DY7CvTp53X7PaYtXe6EY1qdauKk/1vg=; b=lvbbAm3CdT+5AmBd RTS7RJ9LUCLAYXQdoAdIf5ZB1ZO0uUlR0UsTZtkFj51lNUCF18cPBuBlTotvvIpj +oLtAu0sgaMoljjQ2XRpDhuiYQ43zHRqFdUB/alEUxb3Tbpuo7Do8O+9Nmzww2bo 1ZQNHfkBpgspHitB/5p0APX8ZDE5tqR6FrKwmkAXGer0TqgpjEN01TDLe9cHLOfn tB3HP0KsujpGmu82FcOnI856l6aMvE7a4m7Mq5jvUyKvECfk8roSmAe9RK9fPtsd D7hWnhZjxFMvGdbT/Gpvy/SPi/PZXztVJ5h2aXTpGzc/FHjKcR+V7ihEJUyBb12J x0YUvQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxdt80pk6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 11:03:50 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aecd4f7ca1so30139905ad.2 for ; Mon, 16 Mar 2026 04:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773659030; x=1774263830; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IKvEpj8o9w79DY7CvTp53X7PaYtXe6EY1qdauKk/1vg=; b=jljJdOFEughrrj+oXp47fBxgtPPHDbWBEWoYpFm5gR7P88rcqnqjUZ9oiYPf3J56fZ k3zu1aGEHqRsZo96I2HV/mCXNil3p9Tej4B/Z72L7ywMHq/G3SO+CZ/4FM8073Ypv2+p j7hRSDFGkL7k1PDrJkDm+P4C1PgL6UYvtW+OPnYVAC0JQwkhRUYHF0xPL1K8gSVk+M56 fwTsWQlYHzKncKierX6dSKYdASngTPUglifZV+4t7c2I41qiwd3m9Z3pNwA2wtdFRgey Emf37BSdGDdHjZFXcmQEouGhfXVnuZ9o3jIy8gxSHxSGVsvvw0wGkfOy2CHf+6Zg1nZ1 X5FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773659030; x=1774263830; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IKvEpj8o9w79DY7CvTp53X7PaYtXe6EY1qdauKk/1vg=; b=kRBoxevzCPzO8I9JHTpz8bOwH+37FZCObrtjsmaMudF1Tl8xvapE8Y+mLuTQsRizmB CAdCtC5pw8g6yCze6VzjOxXttu5fypnRJulC8GXp1PWxsO3b/0DyXWFjeN5mBZKIyYfO quo5oh4pTJOwE8pBLtY1RMjHzSiWiwDU/7hmbXcGi6qk2swPOgGjGv1PnKaY+/sBK/h3 NIiIKoFd3iYv+Lz/vvyLfurJwZfCADGjOWO9Rbd/+zETR4J8Oh4oqwuOcglpHT7+ib9l GupSQ8HrcVMY7T2j7Piml5eoe5F7PdNVNVUo0gPWc3PAzJ0ju7G/uqxzvd91IDoNifsZ q/Xw== X-Forwarded-Encrypted: i=1; AJvYcCUSmBlBkooHHSM642nmrcj6pBX+a0ntF7oBx/pq/FW6dIuwhsxSZcS6tj/cIATxYq1997hfVBzLhl9Jm+I=@vger.kernel.org X-Gm-Message-State: AOJu0YzNAkzDflIAYAOzX4+lobE4RWPYzAnfJIw308KnHXX6EdeqT+qc efzjMgH6HKr5MxAovbaRQgaXqgW5k6NQsGLyvK+FDm+Wl5S07PqF944hd7Jm2UHIRNRBWoKxSre la8mRG13h4L5J5+08yD9uEPkfjUR4r8dqxCJFtH4DmzSD2FVRn6+4nnG0o5KzFvfA7KE= X-Gm-Gg: ATEYQzzPEVGpRqa8/7FRnc8gLx4yQekMo5ROQhIhdainGKaJXJaIaslIpgubpN1FI+i 1qr6B4v0mvv6QX0QAld39zRSBIuZakW8pXuVd+dzbO+TVYo0YfALfoMbmx1qh9QSoA1tKvS9llf hOt15IlPH7koWAPhBVpJO8rTUhZIKXZY/5aTyHx2OUtAkgV5m9cup6ly+ml6VCm3q2AqF7PPrtn ZfzFLs89HVRQ08ix25sFipYwIfApqJpdPELPUJyY1D7AknjS6OdiBkpnPg8hM9h7llpbNzwDtWp q3sM5zSD/7XdnBmMwi5hkTidS507AWu9qonFUChram5irAR2Ts5cwsPmBqClQ6Q8UJPfHgIZ/2Z cUXko230wkTY5tfhJDIRnOOcstQKu325wT4OQqI93f3TpVCPoQicX X-Received: by 2002:a17:903:41c5:b0:2ae:a95e:fe58 with SMTP id d9443c01a7336-2aeca959d3bmr130518905ad.8.1773659029761; Mon, 16 Mar 2026 04:03:49 -0700 (PDT) X-Received: by 2002:a17:903:41c5:b0:2ae:a95e:fe58 with SMTP id d9443c01a7336-2aeca959d3bmr130518455ad.8.1773659029227; Mon, 16 Mar 2026 04:03:49 -0700 (PDT) Received: from [10.218.5.182] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0537b6567sm40971865ad.58.2026.03.16.04.03.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 04:03:48 -0700 (PDT) Message-ID: <5299d711-63db-4d51-888f-c9062b2c7fb6@oss.qualcomm.com> Date: Mon, 16 Mar 2026 16:33:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] clk: qcom: Add support for GXCLK for Milos To: Luca Weiss , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260306-milos-gxclkctl-v1-0-00b09ee159a7@fairphone.com> <20260306-milos-gxclkctl-v1-2-00b09ee159a7@fairphone.com> Content-Language: en-US From: Jagadeesh Kona In-Reply-To: <20260306-milos-gxclkctl-v1-2-00b09ee159a7@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: -RNfKyZrf9WhUwfa613LP8-Lz8km5kQe X-Authority-Analysis: v=2.4 cv=CKInnBrD c=1 sm=1 tr=0 ts=69b7e396 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=m_WPT2mbnHjVYyRV6GoA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-ORIG-GUID: -RNfKyZrf9WhUwfa613LP8-Lz8km5kQe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA4NCBTYWx0ZWRfX4DFccNVn66yj IH9E+HN2hssiT1snOaQGjfVIheJocK5CV76x2UOT0p+gqeWO0IwsTdYF4fMU9DRJihtRQc3FP97 oaLlMUdszbjj8q4rQaol/tHs3LuW6rZwgOYKIyFuKJ0+3mejbmfNTipSKoIzxge1Ws4U8PjtYYa 7ti8t1IxCABae724dGA7ScRAPm2VyKYp8fM1tiWFExQ6XRAA3YGYogIrugL3l3sanPAAM8X2Yah z0Hwh+E3jRJiU9ilRgWQ+Ea1iL0NqIfXyoDdOOXkY5sat74yPTUBtsrtsp6i5UtdssWubOIBWQF ZL5FAMn5euBNg6ISbx3BFKvyJjsIY79pjAGjyGzTZDld2MDyMbVAyR/Atc4AZekRsHwxdgZDiyI MHZaiSg+cyVJBvOuRefNfQsjA3Fb4ozcEu0cVWD4/w/FnWomZXfSjGPUkKMWbOIFq2PyLAMRvqg c7blbDVEMLWif3WGuvw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160084 On 3/6/2026 7:18 PM, Luca Weiss wrote: > GXCLKCTL (Graphics GX Clock Controller) is a block dedicated to managing > clocks for the GPU subsystem on GX power domain. The GX clock controller > driver manages only the GX GDSC and the rest of the resources of the > controller are managed by the firmware. > > We can use the existing kaanapali driver for Milos as well since the > GX_CLKCTL_GX_GDSC supported by the Linux driver requires the same > configuration. > > Signed-off-by: Luca Weiss > --- > drivers/clk/qcom/Makefile | 2 +- > drivers/clk/qcom/gxclkctl-kaanapali.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile > index 90ea21c3b7cf..155830140d26 100644 > --- a/drivers/clk/qcom/Makefile > +++ b/drivers/clk/qcom/Makefile > @@ -182,7 +182,7 @@ obj-$(CONFIG_SM_GPUCC_8350) += gpucc-sm8350.o > obj-$(CONFIG_SM_GPUCC_8450) += gpucc-sm8450.o > obj-$(CONFIG_SM_GPUCC_8550) += gpucc-sm8550.o > obj-$(CONFIG_SM_GPUCC_8650) += gpucc-sm8650.o > -obj-$(CONFIG_SM_GPUCC_MILOS) += gpucc-milos.o > +obj-$(CONFIG_SM_GPUCC_MILOS) += gpucc-milos.o gxclkctl-kaanapali.o > obj-$(CONFIG_SM_LPASSCC_6115) += lpasscc-sm6115.o > obj-$(CONFIG_SM_TCSRCC_8550) += tcsrcc-sm8550.o > obj-$(CONFIG_SM_TCSRCC_8650) += tcsrcc-sm8650.o > diff --git a/drivers/clk/qcom/gxclkctl-kaanapali.c b/drivers/clk/qcom/gxclkctl-kaanapali.c > index 3ee512f34967..d3899420d6f2 100644 > --- a/drivers/clk/qcom/gxclkctl-kaanapali.c > +++ b/drivers/clk/qcom/gxclkctl-kaanapali.c > @@ -54,6 +54,7 @@ static const struct qcom_cc_desc gx_clkctl_kaanapali_desc = { > static const struct of_device_id gx_clkctl_kaanapali_match_table[] = { > { .compatible = "qcom,glymur-gxclkctl" }, > { .compatible = "qcom,kaanapali-gxclkctl" }, > + { .compatible = "qcom,milos-gxclkctl" }, > { } > }; > MODULE_DEVICE_TABLE(of, gx_clkctl_kaanapali_match_table); > Reviewed-By: Jagadeesh Kona Thanks, Jagadeesh