Re: [PATCHv4] ARM: tegra: add gpiod_lookup table for paz00

[Alex Courbot <acourbot@nvidia.com>]

On 12/03/2013 09:49 PM, Heikki Krogerus wrote:
> This makes it possible to request the gpio descriptors in
> rfkill_gpio driver regardless of the platform.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>   arch/arm/mach-tegra/board-paz00.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> Changes since v3:
> -----------------
> Rebased on top of Alexandre's patch "gpio: better lookup method for
> platform GPIOs".
>
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> index 06f0240..e4dec9f 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -18,6 +18,7 @@
>    */
>
>   #include <linux/platform_device.h>
> +#include <linux/gpio/driver.h>
>   #include <linux/rfkill-gpio.h>
>   #include "board.h"
>
> @@ -36,7 +37,17 @@ static struct platform_device wifi_rfkill_device = {
>   	},
>   };
>
> +static struct gpiod_lookup_table wifi_gpio_lookup = {
> +	.dev_id = "rfkill_gpio",
> +	.table = {
> +		GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
> +		GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),

nit: the flags could be changed to GPIO_ACTIVE_HIGH (which evaluates to 
0) to be more explicit.