From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755651Ab3LDMWq (ORCPT ); Wed, 4 Dec 2013 07:22:46 -0500 Received: from 7of9.schinagl.nl ([88.159.158.68]:32869 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753663Ab3LDMWn (ORCPT ); Wed, 4 Dec 2013 07:22:43 -0500 Message-ID: <529F1C88.5070701@schinagl.nl> Date: Wed, 04 Dec 2013 13:14:00 +0100 From: Olliver Schinagl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: oliver@schinagl.nl CC: tj@kernel.org, grant.likely@linaro.org, rob.herring@calxeda.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dev@linux-sunxi.org, maxime.ripard@free-electrons.com, ijc@hellion.org.uk, hdegoede@redhat.com Subject: Re: [PATCH 0/3] AHCI: sunxi: Add sunxi AHCI driver References: <1386159055-10264-1-git-send-email-oliver@schinagl.nl> In-Reply-To: <1386159055-10264-1-git-send-email-oliver@schinagl.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org And I've spotted my first mistake (one of many I'm sure) I typo'ed Rob's e-mail address. Sorry Rob. Oliver On 04-12-13 13:10, oliver@schinagl.nl wrote: > From: Olliver Schinagl > > This patch series adds Allwinner sunxi support to platform_ahci. > There are a few quirks here however that will need discussing. > > Allwinner added something to setup the DMA engine prior to enabling DMA in > libahci.c. I'm not familiar at all with the AHCI spec and not sure what > the proper way to implement this would have been. Don't other platforms > optionally require the same thing? > > Also the way ahci_platform works seems a little hack-ish, it seems like > something along the lines of ahci_platform_register(ahci-data) would be more > appropriate, but not sure yet on those details (I am just a beginner). > > Furthermore this driver should, in theory, work on the A10 but on my > cubieboard 1 it does not work yet (just hangs somewhere in libahci or after, > but not the DMA call that was altered). I've also tested it the cubietruck, > cubieboard 2 and olinuxino and it worked fine there. > > Thanks, > > Oliver > > Oliver Schinagl (3): > RFC: AHCI: libahci is missing DMA > ARM: sunxi: Add an ahci-platform compatible AHCI driver for the > Allwinner SUNXi series of SoCs > ARM: sunxi: dts: Add ahci support to a few A10 and A20 boards > > .../devicetree/bindings/ata/ahci-sunxi.txt | 24 ++ > arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 26 ++ > arch/arm/boot/dts/sun4i-a10.dtsi | 9 + > arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 26 ++ > arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 26 ++ > arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 26 ++ > arch/arm/boot/dts/sun7i-a20.dtsi | 9 + > drivers/ata/Kconfig | 9 + > drivers/ata/Makefile | 1 + > drivers/ata/ahci.h | 6 + > drivers/ata/ahci_platform.c | 12 + > drivers/ata/ahci_sunxi.c | 305 +++++++++++++++++++++ > drivers/ata/libahci.c | 8 + > 13 files changed, 487 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ata/ahci-sunxi.txt > create mode 100644 drivers/ata/ahci_sunxi.c >