From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Hugues Fruchet <hugues.fruchet@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Philipp Zabel <p.zabel@pengutronix.de>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Sebastian Fricke <sebastian.fricke@collabora.com>,
Ricardo Ribalda <ribalda@chromium.org>,
Erling Ljunggren <hljunggr@cisco.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/3] media: verisilicon: postproc: 4K support
Date: Tue, 22 Apr 2025 15:58:02 -0400 [thread overview]
Message-ID: <529a9804d5b14322b2be78ea6f98677db9c23c33.camel@ndufresne.ca> (raw)
In-Reply-To: <20241121131904.261230-4-hugues.fruchet@foss.st.com>
Hi,
Le jeudi 21 novembre 2024 à 14:19 +0100, Hugues Fruchet a écrit :
> Support input larger than 4096x2048 using extended input width/height
> fields of swreg92.
> This is needed to decode large WebP or JPEG pictures.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> drivers/media/platform/verisilicon/hantro.h | 2 ++
> drivers/media/platform/verisilicon/hantro_g1_regs.h | 2 +-
> drivers/media/platform/verisilicon/hantro_postproc.c | 6 +++++-
> 3 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/verisilicon/hantro.h b/drivers/media/platform/verisilicon/hantro.h
> index 811260dc3c77..d1337f7742e4 100644
> --- a/drivers/media/platform/verisilicon/hantro.h
> +++ b/drivers/media/platform/verisilicon/hantro.h
> @@ -321,6 +321,8 @@ struct hantro_postproc_regs {
> struct hantro_reg output_fmt;
> struct hantro_reg orig_width;
> struct hantro_reg display_width;
> + struct hantro_reg input_width_ext;
> + struct hantro_reg input_height_ext;
> };
>
> struct hantro_vp9_decoded_buffer_info {
> diff --git a/drivers/media/platform/verisilicon/hantro_g1_regs.h b/drivers/media/platform/verisilicon/hantro_g1_regs.h
> index e7d4db788e57..f6e5bbeb1914 100644
> --- a/drivers/media/platform/verisilicon/hantro_g1_regs.h
> +++ b/drivers/media/platform/verisilicon/hantro_g1_regs.h
> @@ -351,7 +351,7 @@
> #define G1_REG_PP_CONTROL_OUT_WIDTH(v) (((v) << 4) & GENMASK(14, 4))
> #define G1_REG_PP_MASK1_ORIG_WIDTH G1_SWREG(88)
> #define G1_REG_PP_ORIG_WIDTH(v) (((v) << 23) & GENMASK(31, 23))
> -#define G1_REG_PP_DISPLAY_WIDTH G1_SWREG(92)
> +#define G1_REG_PP_DISPLAY_WIDTH_IN_EXT G1_SWREG(92)
> #define G1_REG_PP_FUSE G1_SWREG(99)
>
> #endif /* HANTRO_G1_REGS_H_ */
> diff --git a/drivers/media/platform/verisilicon/hantro_postproc.c b/drivers/media/platform/verisilicon/hantro_postproc.c
> index 232c93eea7ee..84c8e287470d 100644
> --- a/drivers/media/platform/verisilicon/hantro_postproc.c
> +++ b/drivers/media/platform/verisilicon/hantro_postproc.c
> @@ -49,7 +49,9 @@ static const struct hantro_postproc_regs hantro_g1_postproc_regs = {
> .input_fmt = {G1_REG_PP_CONTROL, 29, 0x7},
> .output_fmt = {G1_REG_PP_CONTROL, 26, 0x7},
> .orig_width = {G1_REG_PP_MASK1_ORIG_WIDTH, 23, 0x1ff},
> - .display_width = {G1_REG_PP_DISPLAY_WIDTH, 0, 0xfff},
> + .display_width = {G1_REG_PP_DISPLAY_WIDTH_IN_EXT, 0, 0xfff},
> + .input_width_ext = {G1_REG_PP_DISPLAY_WIDTH_IN_EXT, 26, 0x7},
> + .input_height_ext = {G1_REG_PP_DISPLAY_WIDTH_IN_EXT, 29, 0x7},
> };
>
> bool hantro_needs_postproc(const struct hantro_ctx *ctx,
> @@ -103,6 +105,8 @@ static void hantro_postproc_g1_enable(struct hantro_ctx *ctx)
> HANTRO_PP_REG_WRITE(vpu, output_height, ctx->dst_fmt.heighat);
> HANTRO_PP_REG_WRITE(vpu, orig_width, MB_WIDTH(ctx->dst_fmt.width));
> HANTRO_PP_REG_WRITE(vpu, display_width, ctx->dst_fmt.width);
> + HANTRO_PP_REG_WRITE(vpu, input_width_ext, MB_WIDTH(ctx->dst_fmt.width) >> 9);
> + HANTRO_PP_REG_WRITE(vpu, input_height_ext, MB_HEIGHT(ctx->dst_fmt.height >> 8));
> }
>
> static int down_scale_factor(struct hantro_ctx *ctx)
next prev parent reply other threads:[~2025-04-22 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 13:19 [PATCH v3 0/3] Add WebP support to hantro decoder Hugues Fruchet
2024-11-21 13:19 ` [PATCH v3 1/3] media: uapi: add WebP uAPI Hugues Fruchet
2025-04-22 19:53 ` Nicolas Dufresne
2024-11-21 13:19 ` [PATCH v3 2/3] media: verisilicon: add WebP decoding support Hugues Fruchet
2025-04-22 20:02 ` Nicolas Dufresne
2024-11-21 13:19 ` [PATCH v3 3/3] media: verisilicon: postproc: 4K support Hugues Fruchet
2025-04-22 19:58 ` Nicolas Dufresne [this message]
2024-11-21 14:16 ` [PATCH v3 0/3] Add WebP support to hantro decoder Hugues FRUCHET
2024-11-24 3:09 ` Adam Ford
2024-11-25 7:49 ` Hugues FRUCHET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529a9804d5b14322b2be78ea6f98677db9c23c33.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=alexandre.torgue@foss.st.com \
--cc=benjamin.gaignard@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hljunggr@cisco.com \
--cc=hugues.fruchet@foss.st.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jeanmichel.hautbois@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sebastian.fricke@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®