From: Hans Verkuil <hverkuil@xs4all.nl>
To: Guilherme Gallo <gagallo7@gmail.com>,
Helen Koike <helen.koike@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH v2] media: vimc: implement basic v4l2-ctrls
Date: Tue, 4 Sep 2018 08:40:20 +0200 [thread overview]
Message-ID: <529ce419-bba7-7e90-cb7d-e9a94fe64ac2@xs4all.nl> (raw)
In-Reply-To: <20180904014559.15765-1-gagallo7@gmail.com>
Hi Guilherme,
On 09/04/2018 03:45 AM, Guilherme Gallo wrote:
> Add brightness, contrast, hue and saturation controls in vimc-sensor
>
> Signed-off-by: Guilherme Alcarde Gallo <gagallo7@gmail.com>
> Signed-off-by: Guilherme Gallo <gagallo7@gmail.com>
Looks good, but you have (probably unintended) two Signed-off-by lines.
Just let me know which one I should use and I'll drop the other one.
Regards,
Hans
> ---
> drivers/media/platform/vimc/vimc-sensor.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/media/platform/vimc/vimc-sensor.c b/drivers/media/platform/vimc/vimc-sensor.c
> index b2b89315e7ba..edf4c85ae63d 100644
> --- a/drivers/media/platform/vimc/vimc-sensor.c
> +++ b/drivers/media/platform/vimc/vimc-sensor.c
> @@ -317,6 +317,18 @@ static int vimc_sen_s_ctrl(struct v4l2_ctrl *ctrl)
> case V4L2_CID_VFLIP:
> tpg_s_vflip(&vsen->tpg, ctrl->val);
> break;
> + case V4L2_CID_BRIGHTNESS:
> + tpg_s_brightness(&vsen->tpg, ctrl->val);
> + break;
> + case V4L2_CID_CONTRAST:
> + tpg_s_contrast(&vsen->tpg, ctrl->val);
> + break;
> + case V4L2_CID_HUE:
> + tpg_s_hue(&vsen->tpg, ctrl->val);
> + break;
> + case V4L2_CID_SATURATION:
> + tpg_s_saturation(&vsen->tpg, ctrl->val);
> + break;
> default:
> return -EINVAL;
> }
> @@ -378,6 +390,14 @@ static int vimc_sen_comp_bind(struct device *comp, struct device *master,
> V4L2_CID_VFLIP, 0, 1, 1, 0);
> v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> V4L2_CID_HFLIP, 0, 1, 1, 0);
> + v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> + V4L2_CID_BRIGHTNESS, 0, 255, 1, 128);
> + v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> + V4L2_CID_CONTRAST, 0, 255, 1, 128);
> + v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> + V4L2_CID_HUE, -128, 127, 1, 0);
> + v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> + V4L2_CID_SATURATION, 0, 255, 1, 128);
> vsen->sd.ctrl_handler = &vsen->hdl;
> if (vsen->hdl.error) {
> ret = vsen->hdl.error;
>
next prev parent reply other threads:[~2018-09-04 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 1:45 Guilherme Gallo
2018-09-04 6:40 ` Hans Verkuil [this message]
2018-09-04 22:54 ` Guilherme Alcarde Gallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529ce419-bba7-7e90-cb7d-e9a94fe64ac2@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=gagallo7@gmail.com \
--cc=helen.koike@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®