From: "Jan Beulich" <JBeulich@suse.com>
To: "John Stultz" <john.stultz@linaro.org>
Cc: "David Vrabel" <david.vrabel@citrix.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>, <xen-devel@lists.xen.org>,
"Prarit Bhargava" <prarit@redhat.com>,
"LKML" <linux-kernel@vger.kernel.org>,
"stable" <stable@vger.kernel.org>
Subject: Re: [Xen-devel] [RFC][PATCH 3/3] timekeeping: Fix potential lost pv notification of time change
Date: Tue, 10 Dec 2013 08:13:08 +0000 [thread overview]
Message-ID: <52A6DB24020000780010BAC6@nat28.tlf.novell.com> (raw)
In-Reply-To: <1386652197-7035-4-git-send-email-john.stultz@linaro.org>
>>> On 10.12.13 at 06:09, John Stultz <john.stultz@linaro.org> wrote:
> static cycle_t logarithmic_accumulation(struct timekeeper *tk, cycle_t offset,
> - u32 shift)
> + u32 shift, int *action)
With plain int used here, ...
> @@ -1369,7 +1369,7 @@ static void update_wall_time(void)
> struct timekeeper *tk = &shadow_timekeeper;
> cycle_t offset;
> int shift = 0, maxshift;
> - unsigned int action;
> + unsigned int action = 0;
... and unsigned int used here, ...
> @@ -1404,7 +1404,7 @@ static void update_wall_time(void)
> maxshift = (64 - (ilog2(ntp_tick_length())+1)) - 1;
> shift = min(shift, maxshift);
> while (offset >= tk->cycle_interval) {
> - offset = logarithmic_accumulation(tk, offset, shift);
> + offset = logarithmic_accumulation(tk, offset, shift, &action);
... does this compile without warning for you?
Jan
next prev parent reply other threads:[~2013-12-10 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 5:09 [RFC][PATCH 0/3] Couple of timekeeping fixes John Stultz
2013-12-10 5:09 ` [RFC][PATCH 1/3] timekeeping: Fix lost updates to tai adjustment John Stultz
2013-12-10 5:09 ` [RFC][PATCH 2/3] timekeeping: Fix missing timekeeping_update in suspend path John Stultz
2013-12-10 5:09 ` [RFC][PATCH 3/3] timekeeping: Fix potential lost pv notification of time change John Stultz
2013-12-10 8:13 ` Jan Beulich [this message]
2013-12-10 22:30 ` [Xen-devel] " John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6DB24020000780010BAC6@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=david.vrabel@citrix.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®