mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: fweisbec@gmail.com
Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org,
	oleg@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH 02/10 v2] posix-timers: Remove dead process posix cpu timers caching
Date: Tue, 10 Dec 2013 14:54:48 -0500	[thread overview]
Message-ID: <52A77188.50200@jp.fujitsu.com> (raw)
In-Reply-To: <1386611931-4658-1-git-send-email-fweisbec@gmail.com>

(12/9/2013 12:58 PM), Frederic Weisbecker wrote:
> Now that we removed dead thread posix cpu timers caching,
> lets remove the dead process wide version. This caching
> is similar to the per thread version but it should be even
> more rare:
> 
> * If the process id dead, we are not reading its timers
> status from a thread belonging to its group since they
> are all dead. So this caching only concern remote process
> timers reads. Now posix cpu timers using itimers or timer_settime()
> can't do remote process timers anyway so it's not even clear if there
> is actually a user for this caching.
> 
> * Unlike per thread timers caching, this only applies to
> zombies targets. Buried targets' process wide timers return
> 0 values. But then again, timer_gettime() can't read remote
> process timers, so if the process is dead, there can't be
> any reader left anyway.
> 
> Then again this caching seem to complicate the code for
> corner cases that are probably not worth it. So lets get
> rid of it.
> 
> Also remove the sample snapshot on dying process timer
> that is now useless, as suggested by Kosaki.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Kosaki Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>

Looks good to me.

Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>




      reply	other threads:[~2013-12-10 19:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09 17:58 Frederic Weisbecker
2013-12-10 19:54 ` KOSAKI Motohiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A77188.50200@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®