On 12/13/2013 03:50 PM, Greg KH wrote: > On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: >> From: Rebecca Schultz Zavin >> >> Signed-off-by: Rebecca Schultz Zavin >> [jstultz: Squished in Colin Cross' move to staging change] >> Signed-off-by: John Stultz >> --- >> drivers/staging/android/Kconfig | 2 + >> drivers/staging/android/Makefile | 2 + > This patch breaks the build if this option is enabled. > > I suggest only adding the driver to the build _after_ it can be built, > for obvious reasons :) > > Other than this "minor" thing, I have no objection to these patches at > all. Can you redo this patch to fix this up, and maybe send another > patch adding it to the build and let me know at what point in the series > it should be applied? Ok. Two patches attached. I ended up just yanking the build directory since disabling the config option caused trivial collisions in the series. 0001-ion-Disable-ION-as-it-doesn-t-build.patch - This can be folded in after the first patch. 0117-ion-Reenable-the-build.patch - This can be applied to the end of the series, or folded into the last patch "ion: Update system heap shrinker to use the new count/scan interface" Let me know if you'd rather this be done some other way. Also let me know if you've still not seen the other patches in the series. thanks -john