From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753369Ab3LSIzG (ORCPT ); Thu, 19 Dec 2013 03:55:06 -0500 Received: from 8.mo3.mail-out.ovh.net ([87.98.172.249]:43471 "EHLO mo3.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753062Ab3LSIzD (ORCPT ); Thu, 19 Dec 2013 03:55:03 -0500 Message-ID: <52B2B42F.9010202@overkiz.com> Date: Thu, 19 Dec 2013 09:54:07 +0100 From: boris brezillon User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Mike Turquette , Rob Landley , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Russell King , Nicolas Ferre , =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaQ==?= =?UTF-8?B?Zw==?= CC: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/2] clk: add clk accuracy retrieval support References: <1387290983-6236-1-git-send-email-b.brezillon@overkiz.com> <1387290983-6236-2-git-send-email-b.brezillon@overkiz.com> <20131219060431.18119.64699@quantum> In-Reply-To: <20131219060431.18119.64699@quantum> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 12989788702090688540 X-Ovh-Remote: 80.245.18.66 () X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejtddrtddvucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejtddrtddvucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mike, On 19/12/2013 07:04, Mike Turquette wrote: > Quoting Boris BREZILLON (2013-12-17 06:36:22) >> +unsigned long __clk_get_accuracy(struct clk *clk) >> +{ >> + unsigned long ret; >> + >> + if (!clk) >> + return 0; >> + >> + return clk->accuracy; >> +} >> +EXPORT_SYMBOL_GPL(__clk_get_accuracy); > Any reason for exporting this? This might be used by clk drivers to choose the most accurate clk among its parent clks (within the determinate_rate callback). And as some clk drivers might be compiled as modules we need to export the symbol (__clk_get_name helper function is exported too). Best Regards, Boris > > Regards, > Mike