mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Mikulas Patocka <mpatocka@redhat.com>,
	Jeff Mahoney <jeffm@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	torvalds@linux-foundation.org,
	device-mapper development <dm-devel@redhat.com>
Cc: paulmck@linux.vnet.ibm.com, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, mingo@kernel.org
Subject: Re: [dm-devel] [PATCH] kobject: provide kobject_put_wait to fix module unload race
Date: Sun, 05 Jan 2014 17:43:56 +0100	[thread overview]
Message-ID: <52C98BCC.9040900@acm.org> (raw)
In-Reply-To: <alpine.LRH.2.02.1401021733250.27775@file01.intranet.prod.int.rdu2.redhat.com>

On 01/04/14 19:06, Mikulas Patocka wrote:
> -	if (t && !t->release)
> -		pr_debug("kobject: '%s' (%p): does not have a release() "
> -			 "function, it is broken and must be fixed.\n",
> -			 kobject_name(kobj), kobj);
> -

Has it been considered to issue a warning if no release function has
been defined and free_completion == NULL instead of removing the above
debug message entirely ? I think even with this patch applied it is
still wrong to invoke kobject_put() on an object without defining a
release function.

Thanks,

Bart.


  parent reply	other threads:[~2014-01-05 16:44 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-04 18:06 Mikulas Patocka
2014-01-04 18:14 ` Jeff Mahoney
2014-01-05  3:48   ` Greg Kroah-Hartman
2014-01-04 18:16 ` Greg Kroah-Hartman
2014-01-04 18:34   ` Al Viro
2014-01-04 22:42     ` Dmitry Torokhov
2014-01-05 22:11       ` Mikulas Patocka
2014-01-05 22:39         ` Dmitry Torokhov
2014-01-06 18:43           ` Mikulas Patocka
2014-01-04 20:35   ` Mikulas Patocka
2014-01-05  3:42     ` Greg Kroah-Hartman
2014-01-05  6:05       ` Dmitry Torokhov
2014-01-05 18:27         ` Greg Kroah-Hartman
2014-01-05 22:04       ` Mikulas Patocka
2014-01-05 22:23         ` Greg Kroah-Hartman
2014-01-05 16:43 ` Bart Van Assche [this message]
2014-01-05 18:26   ` [dm-devel] " Greg Kroah-Hartman
2014-01-06 18:55     ` Mikulas Patocka
2014-01-06 19:23       ` Greg Kroah-Hartman
2014-01-06 21:31       ` Mike Snitzer
2014-01-07  4:01         ` Mikulas Patocka
2014-01-07  5:25           ` Linus Torvalds
2014-01-07 18:00             ` Mikulas Patocka
2014-01-07 19:19               ` Mike Snitzer
2014-01-07 20:16                 ` Mikulas Patocka
2014-01-07 22:32                   ` Mike Snitzer
2014-01-07 14:16           ` Greg Kroah-Hartman
2014-01-07 18:16             ` Mikulas Patocka
2014-01-07 18:26             ` Dmitry Torokhov
2014-01-05 22:04   ` [dm-devel] [PATCH] " Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C98BCC.9040900@acm.org \
    --to=bvanassche@acm.org \
    --cc=dm-devel@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome