From: "H. Peter Anvin" <hpa@zytor.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Bin Gao <bin.gao@intel.com>,
x86@kernel.org
Subject: Re: [PATCH] x86, tsc: Add missing Baytrail frequency to the table
Date: Thu, 23 Jan 2014 07:30:18 -0800 [thread overview]
Message-ID: <52E1358A.7020206@zytor.com> (raw)
In-Reply-To: <20140123150912.7ee822a0@alan.etchedpixels.co.uk>
On 01/23/2014 07:09 AM, One Thousand Gnomes wrote:
> On Thu, 23 Jan 2014 13:04:03 +0200
> Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
>
>> Baytrail is based on Silvermont core so MSR_FSB_FREQ[2:0] == 0 means that
>> the CPU reference clock runs at 83.3MHz. Without this we crash a bit later
>> with backtrace looking like:
>
> Would it not be wise to also make the code robust against future failures
> of this kind and at least bitch rather than divide by 0 ?
>
Chicken! ;)
-hpa
next prev parent reply other threads:[~2014-01-23 15:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 11:04 Mika Westerberg
2014-01-23 15:09 ` One Thousand Gnomes
2014-01-23 15:30 ` H. Peter Anvin [this message]
2014-01-23 15:35 ` Mika Westerberg
2014-01-24 8:46 ` [PATCH v2] " Mika Westerberg
[not found] ` <4460FA1017EA3844B646E90DA4E984057D5A4E9F@ORSMSX103.amr.corp.intel.com>
2014-01-25 9:09 ` Bin Gao
2014-01-27 10:20 ` Mika Westerberg
2014-01-28 12:04 ` Mika Westerberg
2014-01-29 21:47 ` Bin Gao
2014-02-04 13:28 ` Mika Westerberg
2014-02-06 5:44 ` Ingo Molnar
2014-02-06 11:49 ` [PATCH v3 1/2] x86, tsc: Fallback to normal calibration if fast MSR calibration fails Mika Westerberg
2014-02-06 11:49 ` [PATCH v3 2/2] x86, tsc: Add missing Baytrail frequency to the table Mika Westerberg
2014-02-06 14:34 ` [PATCH v3 1/2] x86, tsc: Fallback to normal calibration if fast MSR calibration fails Thomas Gleixner
2014-02-06 15:11 ` Mika Westerberg
2014-02-09 14:20 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E1358A.7020206@zytor.com \
--to=hpa@zytor.com \
--cc=bin.gao@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome