From: "Jan Beulich" <JBeulich@suse.com>
To: "Mukesh Rathor" <mukesh.rathor@oracle.com>
Cc: <roger.pau@citrix.com>,
"xen-devel" <xen-devel@lists.xenproject.org>,
<konrad.wilk@oracle.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [V0 PATCH] pvh: Disable PSE feature for now
Date: Tue, 28 Jan 2014 10:39:23 +0000 [thread overview]
Message-ID: <52E796EB0200007800117804@nat28.tlf.novell.com> (raw)
In-Reply-To: <1390875519-8667-2-git-send-email-mukesh.rathor@oracle.com>
>>> On 28.01.14 at 03:18, Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
> Until now, xen did not expose PSE to pvh guest, but a patch was submitted
> to xen list to enable bunch of features for a pvh guest. PSE has not been
> looked into for PVH, so until we can do that and test it to make sure it
> works, disable the feature to avoid flood of bugs.
>
> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
> ---
> arch/x86/xen/enlighten.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index a4d7b64..4e952046 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1497,6 +1497,11 @@ static void __init xen_pvh_early_guest_init(void)
> xen_have_vector_callback = 1;
> xen_pvh_set_cr_flags(0);
>
> + /* pvh guests are not quite ready for large pages yet */
> + setup_clear_cpu_cap(X86_FEATURE_PSE);
> + setup_clear_cpu_cap(X86_FEATURE_PSE36);
And why would you not want to also turn of 1Gb pages then?
Jan
next prev parent reply other threads:[~2014-01-28 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 2:18 pvh: disable pse " Mukesh Rathor
2014-01-28 2:18 ` [V0 PATCH] pvh: Disable PSE " Mukesh Rathor
2014-01-28 3:46 ` Konrad Rzeszutek Wilk
2014-01-29 2:28 ` Mukesh Rathor
2014-01-28 10:39 ` Jan Beulich [this message]
2014-01-29 2:30 ` [Xen-devel] " Mukesh Rathor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E796EB0200007800117804@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®