From: Hans de Goede <hdegoede@redhat.com>
To: Sergio de Almeida Cipriano Junior <sergiosacj@riseup.net>
Cc: ~lkcamp/patches@lists.sr.ht, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, helen.koike@collabora.com
Subject: Re: [PATCH] media: atomisp: move trailing */ to separate lines
Date: Mon, 2 Sep 2024 12:10:58 +0200 [thread overview]
Message-ID: <52a23d6c-b50c-4079-b0e7-4c1ca2fbc394@redhat.com> (raw)
In-Reply-To: <20240730071904.1047-1-sergiosacj@riseup.net>
Hi,
On 7/30/24 9:19 AM, Sergio de Almeida Cipriano Junior wrote:
> Fix checkpatch diagnostic "WARNING: Block comments use a trailing */ on
> a separate line" in assert_support.h file.
>
> Signed-off-by: Sergio de Almeida Cipriano Junior <sergiosacj@riseup.net>
Thank you for your patch(es).
I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)
Regards,
Hans
> ---
> Hi, this is my first patch to the kernel.
> ---
> .../media/atomisp/pci/hive_isp_css_include/assert_support.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/assert_support.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/assert_support.h
> index d294ac402..c5ab13511 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/assert_support.h
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/assert_support.h
> @@ -27,7 +27,8 @@
> * #define assert(cnd) BUG_ON(cnd)
> * but that causes many compiler warnings (==errors) under Android
> * because it seems that the BUG_ON() macro is not seen as a check by
> - * gcc like the BUG() macro is. */
> + * gcc like the BUG() macro is.
> + */
> #define assert(cnd) \
> do { \
> if (!(cnd)) \
> @@ -37,7 +38,8 @@
> #ifndef PIPE_GENERATION
> /* Deprecated OP___assert, this is still used in ~1000 places
> * in the code. This will be removed over time.
> - * The implementation for the pipe generation tool is in see support.isp.h */
> + * The implementation for the pipe generation tool is in see support.isp.h
> + */
> #define OP___assert(cnd) assert(cnd)
>
> static inline void compile_time_assert(unsigned int cond)
prev parent reply other threads:[~2024-09-02 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 7:19 Sergio de Almeida Cipriano Junior
2024-09-02 10:10 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52a23d6c-b50c-4079-b0e7-4c1ca2fbc394@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=helen.koike@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergiosacj@riseup.net \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®